Repository navigation
fix(topcompanies): compare commits, not PRs, when ranking by contributions - #255
Merged
Progi1984 merged 1 commit intoSep 30, 2026
Conversation
…tions The contributions ranking compared the previous company's contributions with the current company's merged PRs, so companies with the same number of commits got different ranks (e.g. Head Issue, ShopRunners and Web Cooking Factory, 6 commits each, ranked 23, 24 and 25). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Progi1984
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
traces:generate:topcompanies, the contributions ranking loop stores$lastScore = $company->contributions, but compares it with$company->mergedPullRequests. The two almost never match, so the rank goes up for every company and ties are ignored.On a local run, 15 companies share their commit count with the previous one but get a different rank. For example, Head Issue, ShopRunners and Web Cooking Factory (6 commits each) are ranked 23, 24 and 25.
Fix
Compare with
$company->contributions, as the PR ranking above does withmergedPullRequests.Verification
topcompanies.jsonlocally: equal commit counts now always share a rank, and different counts always get different ranks (the 6-commit companies above now all share Exclude more bots #22).🤖 Generated with Claude Code