Skip to content

feat: add accessible compare markets modal#424

Open
pq198363-ops wants to merge 1 commit into
Predictify-org:mainfrom
pq198363-ops:bounty-368-compare-markets-modal
Open

feat: add accessible compare markets modal#424
pq198363-ops wants to merge 1 commit into
Predictify-org:mainfrom
pq198363-ops:bounty-368-compare-markets-modal

Conversation

@pq198363-ops

Copy link
Copy Markdown

Closes #368

Summary

  • Add CompareMarketsModal with an accessible side-by-side comparison of two prediction markets
  • Wire a Compare action into the event detail header using the current market and a related comparison market
  • Document the visible behavior and accessibility notes
  • Fix the existing DialogContentWithFocusReturn useRef reference so the shared dialog module type-checks/lints when imported

Validation

  • PASS: node node_modules/jest/bin/jest.js app/components/__tests__/CompareMarketsModal.test.tsx --runInBand
  • PASS: node node_modules/eslint/bin/eslint.js app/components/CompareMarketsModal.tsx app/components/__tests__/CompareMarketsModal.test.tsx "app/(dashboard)/events/event-page/EventDetailsClient.tsx" components/ui/dialog.tsx
  • PASS: git diff --check
  • NOTE: node node_modules/typescript/bin/tsc --noEmit --pretty false still fails on existing unrelated repo errors such as missing ErrorBoundary, shareProfile, wallet modal symbols, badge variant typing, and existing PredictionCard identifiers.

Notes

  • The modal uses the shared Radix dialog wrapper for focus trapping and Escape handling.
  • The comparison layout stacks on small screens and switches to two columns on wider screens.

@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

@pq198363-ops is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add accessible 'Compare markets' modal

1 participant