feat: add accessible about market modal#423
Open
pq198363-ops wants to merge 1 commit into
Open
Conversation
|
@pq198363-ops is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #362
Summary
AboutMarketModalwith an accessibleAbout this marketdialog for market premise, category, deadline, and resolution criteriaDialogContentWithFocusReturnuseRefreference so the shared dialog module type-checks correctlyValidation
node node_modules/jest/bin/jest.js app/components/__tests__/AboutMarketModal.test.tsx --runInBandnode node_modules/eslint/bin/eslint.js app/components/AboutMarketModal.tsx app/components/__tests__/AboutMarketModal.test.tsx "app/(dashboard)/events/event-page/EventDetailsClient.tsx" components/ui/dialog.tsxnode node_modules/typescript/bin/tsc --noEmit --pretty falsestill fails on existing unrelated repo errors such as missingErrorBoundary,shareProfile,LanguageBadge, wallet modal symbols, and existingPredictionCardidentifiers.Notes
app/markets/[id]/page.tsx, but this repo's current market detail surface isapp/(dashboard)/events/event-page/EventDetailsClient.tsx, so the modal is wired there.