Repository navigation
S3: implement support for session token - #156
Merged
Merged
Conversation
neilcook
reviewed
Aug 13, 2026
ahouene
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for session tokens to be used along the access key id and the secret access key in the S3 backend, directly or through a file.
It also adds support for trailing newlines in those files.
The tests have been updated to take these additions into account. The test against the full test suite in case credential files are used is being removed because it doesn't bring much and just makes the tests longer. Instead, we test that the S3 Backend is correctly created and can (or cannot) perform a write operation with various file contents.