fix(desktop): keep the x64 release build on the boot smoke - #97148
Closed
webjunkie wants to merge 1 commit into
Closed
fix(desktop): keep the x64 release build on the boot smoke#97148webjunkie wants to merge 1 commit into
webjunkie wants to merge 1 commit into
Conversation
The first release after #96677 ran the full Electron suite on both macOS builds. The arm64 build finished it in about a minute; the x64 build under Rosetta took 12.7 minutes and timed out in the subframe navigation test, so finalize-release skipped and desktop-v0.61.295 never shipped. Run the whole suite on the native build only and keep the smoke spec on x64, which is what it ran before. Claude-Session: https://claude.ai/code/session_01AAfrGhk4pdw6Y4X5pEnb9f
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
🤖 CI report
|
Contributor
Author
|
Closing. #97145 fixed the test itself, so the full suite stays on the x64 leg. Falling back to the smoke spec is a two-line change if another test turns out to depend on wall-clock under Rosetta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
desktop-v0.61.295but never shipped: the x64 macOS build failed and finalize skipped (run).Changes
How did you test this code?
actionlintandhogli lint:workflowspass locally.desktop-v*tag. The 17:00 UTC schedule is the first real run.Automatic notifications
Docs update
None.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Fable 5.1). Skills invoked: /authoring-ci-workflows, /writing-code-comments, /writing-pr-descriptions. Follow-up to #96677 after watching its first scheduled run. The simplify pass on that PR had flagged the x64 cost; the first real run confirmed it.
https://claude.ai/code/session_01AAfrGhk4pdw6Y4X5pEnb9f