fix(desktop): stop the CI paths filter skipping runtime markdown - #96675
Merged
Conversation
|
😎 This pull request was merged. |
webjunkie
changed the title
webjunkie
marked this pull request as ready for review
September 8, 2026 13:26
Contributor
🤖 CI report
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a consistent, low-risk narrowing of CI path exclusions that aligns the workflows with runtime Markdown dependencies and preserves fail-closed gating behavior.
Pull request overview
This PR fixes the Desktop CI dorny/paths-filter configuration so PRs that change runtime-loaded Markdown under products/desktop/ no longer skip all Desktop suites.
Changes:
- Narrowed the Desktop workflows’ Markdown exclusions from
!products/desktop/**/*.mdto a small set of documentation-only patterns. - Ensured Markdown under code paths (e.g. bundled agents/skills/templates) now triggers build/quality/typecheck/tests as intended.
- Applied the same filter update consistently across the four Desktop workflows.
File summaries
| File | Description |
|---|---|
| .github/workflows/desktop-typecheck.yml | Updates paths-filter to exclude only doc Markdown so runtime Markdown changes trigger typecheck. |
| .github/workflows/desktop-test.yml | Updates paths-filter to stop skipping unit/integration test suites on runtime Markdown-only changes. |
| .github/workflows/desktop-quality.yml | Updates paths-filter to ignore only documentation Markdown while still running quality checks for runtime Markdown changes. |
| .github/workflows/desktop-build.yml | Updates paths-filter so runtime Markdown changes trigger Desktop build checks. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gantoine
approved these changes
Sep 8, 2026
charlesvien
approved these changes
Sep 8, 2026
|
Stacked PR 96679 failed testing in the merge queue. Please investigate the failure and re-submit the stack. |
The desktop app loads markdown under src/ at runtime: bundled agent prompts, skills, and the canvas templates. The paths filter excluded every .md under products/desktop, so a PR that only edited one of those files skipped build, quality, typecheck and test, and the break landed on master. Exclude documentation markdown only (top-level files, README, AGENTS, CLAUDE, and docs/), so a change to markdown the app reads still runs the suites. Claude-Session: https://claude.ai/code/session_01AAfrGhk4pdw6Y4X5pEnb9f
webjunkie
force-pushed
the
fix/devex-desktop-ci-markdown-filter
branch
from
September 8, 2026 20:17
cc4677e to
1eb84f2
Compare
|
This pull request was merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.mdunderproducts/desktop/.bundled-agents/*.md, severalSKILL.mdfiles and the canvas templates fromsrc/at runtime.Changes
src/now runs build, quality, typecheck and test.README.md,AGENTS.md,CLAUDE.mdanddocs/.Bottom layer of a stack. #96677 gates the release tag on master CI and #96679 moves the Electron e2e suite to Linux.
Follow-up, out of scope here: the four workflows carry the same
changesjob and filter list. A shared composite action would leave one copy to edit.How did you test this code?
hogli lint:workflowsandactionlintpass locally.Automatic notifications
Docs update
None.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Fable 5.1 orchestrating, Opus subagent implementing). Skills invoked: /stacking-prs, /authoring-ci-workflows, /writing-code-comments, /writing-pr-descriptions, /simplify. Found while tracing why #96406 merged red. No open PR fixes the filter; #96427 fixed the tests it broke. Nothing in this PR comes from outside the repository and the public GitHub history.
https://claude.ai/code/session_01AAfrGhk4pdw6Y4X5pEnb9f