Repository navigation
feat(react-native): add $react_native_version to captured events - #5206
Merged
Merged
Conversation
Reads Platform.constants.reactNativeVersion so we can see which React Native versions SDK users run before choosing support floors.
Contributor
|
[Medium risk] Adds React Native version to event properties. The PR appears safe to merge; no new actionable issue remains. Reviews (2) · Last reviewed commit: "chore(react-native): regenerate referenc..." |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…rsion to JS events
turnipdabeets
changed the title
turnipdabeets
marked this pull request as ready for review
October 5, 2026 16:32
4 of 5 tasks
Contributor
Contributor
|
Size Change: +1.09 kB (0%) Total Size: 23.5 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
Node SDK compliance v2Commit: f2c8870 Capture v0✅ 55 passed / ❌ 1 non-passing / Drill-down: run artifacts → ❌ migration:yaml-parity-v1:feature_flags:disable_geoip_omitted_defaults_to_false — failed_assertionFlags field differs Code: Failed step: migration/yaml-parity-v1/remote-flags-v1.feature:143 the first flags request field "geoip_disable" should equal JSON false Operation: Field: Expected: false Actual value: true Harness exit: 1; report validation exit: 1. Capture v1✅ 120 passed / ❌ 1 non-passing / Drill-down: run artifacts → ❌ migration:yaml-parity-v1:feature_flags:disable_geoip_omitted_defaults_to_false — failed_assertionFlags field differs Code: Failed step: migration/yaml-parity-v1/remote-flags-v1.feature:143 the first flags request field "geoip_disable" should equal JSON false Operation: Field: Expected: false Actual value: true Harness exit: 1; report validation exit: 1. |
Contributor
posthog-js Compliance ReportDate: 2026-10-05 16:59:45 UTC ✅ All Tests Passed!26/26 tests passed Capture Tests✅ 26/26 tests passed View Details
|
dustinbyrne
approved these changes
Oct 5, 2026
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We can't tell which React Native versions posthog-react-native users run. Events carry
$lib_version, OS, app and device fields, but no RN version. That leaves support-floor decisions to guesswork, such as the RN 0.71 floor in #5194 and how far back to fix the@posthog/core/surveysresolution failure on RN 0.70–0.78.Changes
$react_native_versionproperty on events captured from JavaScript, for example0.79.6, or0.80.0-rc.2for prereleases. It is read once fromPlatform.constants.reactNativeVersionalong with the other app properties (getAppProperties).0.79.4), so major.minor matches upstream RN but the patch number doesn't. Split by$os_namewhen comparing patch versions.$feature_flag_calledevents: added toMINIMAL_FLAG_CALLED_EVENT_PROPERTIESin@posthog/core(patch changeset), per the sdk-specs feature-flag-called-tracker rule that static runtime-identity properties survive minimization.$os_name,$os_version, …) that the spec's "static platform/runtime identity" category covers.PostHogCustomAppProperties, socustomAppPropertiescan change or remove it like the other app properties.$unity_version, which posthog-unity already sends on exception events. No sdk-specs spec covers default event properties.Release info Sub-libraries affected
Libraries affected
Checklist
test/react-native-version.spec.ts: version format, prerelease, missing or malformed value, throwing lookup, sent on JS events, omitted when absent)Platform.constants; web doesn't, so the property is left out)If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Written with Claude Code while reviewing the RN version floor for
@posthog/react-native-plugin3.0 (#5194), where we had no data on which RN versions are in use.Checks run: posthog-react-native unit tests (72 files, 1238 tests),
@posthog/coreunit tests (2075 passed), posthog-node unit tests (1105) and the browser feature-flag tests (285),check-types, lint andoxfmt. The new "sent with every event" test fails when thegetAppPropertieschange is reverted. On an RN 0.70.15 Android emulator,Platform.constants.reactNativeVersionreported{"major":0,"minor":70,"patch":15,"prerelease":null}, which is the shape this formats. This exact build was not run on a device.🤖 Generated with Claude Code