feat(ai): add prompts.getAll to fetch all prompts at a label by jurajmajerik · Pull Request #4903 · PostHog/posthog-js

jurajmajerik · 2026-09-10T14:05:50Z

Problem

Apps that resolve prompts through a label make one request per prompt per cache cycle. With a few dozen prompts this runs into the API rate limit (Feature request: prompt management - fetch all prompts at a label in one request posthog#95460).
The PostHog list endpoint can now return all prompts at a label in one request (feat(aio): fetch all prompts at a label in one request posthog#96137). This adds the SDK side, mirroring feat(ai): add Prompts.get_all to fetch all prompts at a label posthog-python#938.

Changes

prompts.getAll({ label: 'production' }) fetches every prompt at that label in one call, following pagination, and returns an object of name to result.
Each fetched prompt is stored in the existing cache, so later prompts.get(name, { label }) calls are cache hits. One call per cache cycle instead of one per prompt.
Old servers ignore the label param on the list endpoint and return latest versions. Each row is checked against its all_labels field; if nothing resolves the label, the call throws a clear error instead of caching wrong versions. A single row whose label moved mid-request is skipped with a warning.
Pagination links are only followed on the configured host (the personal API key travels in the Authorization header), and the page safety cap throws instead of returning a truncated result. Both mirror review findings on the Python PR.

Release info Sub-libraries affected

Libraries affected

@posthog/ai

Checklist

Tests for new code
Accounted for the impact of any changes across different platforms
Accounted for backwards compatibility of any changes (no breaking changes!)
Took care not to unnecessarily increase the bundle size

If releasing new changes

Changeset added in .changeset/ (written by hand, same format as pnpm changeset)

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Written with Claude Code, directed by the assignee. Port of feat(ai): add Prompts.get_all to fetch all prompts at a label posthog-python#938, including the fixes from its review (same-origin pagination guard, fail on the page cap, fail loudly on old servers).
Design choice: getAll always fetches (no cache read) so one call refreshes everything, like a feature flag poller.

greptile-apps · 2026-09-10T14:14:43Z

Prompt To Fix All With AI

### Issue 1
packages/ai/src/prompts.ts:301
**Partial matches hide incompatibility**

On an older server that ignores the label filter, some latest prompt versions can match the requested label while others do not. Because this guard throws only when no rows match, `getAll()` returns an incomplete set as a successful result. Callers cannot distinguish the missing prompts from prompts that do not carry the label, and the promised one-request cache warm-up is incomplete.

### Issue 2
packages/ai/src/prompts.ts:276-280
**Malformed rows are silently skipped**

This condition handles malformed rows the same way as valid rows whose label moved. If a response contains valid rows alongside one with a missing or incorrectly typed prompt field, `getAll()` caches and returns only the valid subset instead of rejecting the invalid response. That hides server response errors and leaves callers with an incomplete result, unlike the existing single-prompt fetch path, which throws when response validation fails.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

_{Reviews (1): Last reviewed commit: "feat(ai): add prompts.getAll to fetch al..." | Re-trigger Greptile}

greptile-apps · 2026-09-10T14:14:46Z

+      }
+    }
+
+    if (rows.length > 0 && Object.keys(results).length === 0) {


Partial matches hide incompatibility

On an older server that ignores the label filter, some latest prompt versions can match the requested label while others do not. Because this guard throws only when no rows match, getAll() returns an incomplete set as a successful result. Callers cannot distinguish the missing prompts from prompts that do not carry the label, and the promised one-request cache warm-up is incomplete.

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/ai/src/prompts.ts Line: 301 Comment: **Partial matches hide incompatibility** On an older server that ignores the label filter, some latest prompt versions can match the requested label while others do not. Because this guard throws only when no rows match, `getAll()` returns an incomplete set as a successful result. Callers cannot distinguish the missing prompts from prompts that do not carry the label, and the promised one-request cache warm-up is incomplete. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

fixed in 25a7bd5

greptile-apps · 2026-09-10T14:14:46Z

+      if (!isPromptApiResponse(row) || !rowResolvesLabel(row, label)) {
+        const name = typeof row === 'object' && row !== null ? (row as Record<string, unknown>).name : undefined
+        skipped.push(typeof name === 'string' ? name : '?')
+        continue
+      }


Malformed rows are silently skipped

This condition handles malformed rows the same way as valid rows whose label moved. If a response contains valid rows alongside one with a missing or incorrectly typed prompt field, getAll() caches and returns only the valid subset instead of rejecting the invalid response. That hides server response errors and leaves callers with an incomplete result, unlike the existing single-prompt fetch path, which throws when response validation fails.

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/ai/src/prompts.ts Line: 276-280 Comment: **Malformed rows are silently skipped** This condition handles malformed rows the same way as valid rows whose label moved. If a response contains valid rows alongside one with a missing or incorrectly typed prompt field, `getAll()` caches and returns only the valid subset instead of rejecting the invalid response. That hides server response errors and leaves callers with an incomplete result, unlike the existing single-prompt fetch path, which throws when response validation fails. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

fixed in 3d8197f

marandaneto

Advisory review of the verified PR snapshot.

marandaneto · 2026-09-10T14:23:54Z

+        label,
+        config,
+        fetchedAt: now,
+      })


blocking: Preserve __proto__ as a prompt entry — The API permits the prompt name __proto__, but assigning it into the plain results object changes its prototype instead of creating an own property. This prompt disappears from enumeration and JSON serialization; when it is the only returned prompt, getAll() incorrectly throws the unsupported-server error. Use a dictionary that safely handles arbitrary prompt names. Reproduction: reproduced — pnpm exec vitest run tests/prompts.test.ts tests/prompts-get-all-review.test.ts --coverage.enabled=false in a disposable validation worktree passed all 65 existing tests and failed both added regression cases (missing entry and erroneous exception); both cases passed with a temporary null-prototype result object.

marandaneto

approving to unblock, resolve comments before

…sults

feat(ai): add prompts.getAll to fetch all prompts at a label

061af0c

jurajmajerik self-assigned this Sep 10, 2026

jurajmajerik marked this pull request as ready for review September 10, 2026 14:11

jurajmajerik requested a review from a team as a code owner September 10, 2026 14:11

greptile-apps Bot reviewed Sep 10, 2026

View reviewed changes

marandaneto reviewed Sep 10, 2026

View reviewed changes

marandaneto mentioned this pull request Sep 10, 2026

feat(ai): support batch fetching multiple prompts with getMany (#4353) #4690

Closed

1 task done

jurajmajerik added 2 commits September 10, 2026 16:25

fix(ai): reject a malformed list row instead of skipping it

3d8197f

fix(ai): fail getAll when any returned prompt does not carry the label

25a7bd5

marandaneto approved these changes Sep 10, 2026

View reviewed changes

fix(ai): keep prompt names like __proto__ as own entries in getAll re…

0f73555

…sults

jurajmajerik merged commit 825d830 into main Sep 10, 2026
61 checks passed

jurajmajerik deleted the prompts-get-all-by-label branch September 10, 2026 15:09

jurajmajerik mentioned this pull request Sep 23, 2026

Sprint - September 21 to October 2 PostHog/posthog#101363

Open

Navigation Menu

feat(ai): add prompts.getAll to fetch all prompts at a label - #4903

feat(ai): add prompts.getAll to fetch all prompts at a label#4903
jurajmajerik merged 4 commits into
mainfrom
prompts-get-all-by-label

jurajmajerik commented Sep 10, 2026

Uh oh!

greptile-apps Bot commented Sep 10, 2026

Uh oh!

greptile-apps Bot Sep 10, 2026

Uh oh!

jurajmajerik Sep 10, 2026

Uh oh!

greptile-apps Bot Sep 10, 2026

Uh oh!

jurajmajerik Sep 10, 2026

Uh oh!

marandaneto left a comment

Uh oh!

marandaneto Sep 10, 2026

Uh oh!

jurajmajerik Sep 10, 2026

Uh oh!

marandaneto left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jurajmajerik commented Sep 10, 2026

Problem

Changes

Release info Sub-libraries affected

Libraries affected

Checklist

If releasing new changes

🤖 Agent context

Uh oh!

greptile-apps Bot commented Sep 10, 2026

Uh oh!

greptile-apps Bot Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

jurajmajerik Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

jurajmajerik Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

marandaneto left a comment

Choose a reason for hiding this comment

Uh oh!

marandaneto Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

jurajmajerik Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

marandaneto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants