Repository navigation
chore: update text and names left stale by the 4.0 changes - #910
Merged
Merged
Conversation
Contributor
posthog-ios Compliance ReportDate: 2026-10-06 13:56:42 UTC
|
| Test | Status | Duration |
|---|---|---|
| Format Validation.Event Has Required Fields | ✅ | 2884ms |
| Format Validation.Event Has Uuid | ✅ | 2872ms |
| Format Validation.Event Has Lib Properties | ✅ | 375ms |
| Format Validation.Distinct Id Is String | ✅ | 2749ms |
| Format Validation.Token Is Present | ✅ | 293ms |
| Format Validation.Custom Properties Preserved | ✅ | 2739ms |
| Format Validation.Event Has Timestamp | ✅ | 2754ms |
| Retry Behavior.Retries On 503 | ✅ | 5346ms |
| Retry Behavior.Does Not Retry On 400 | ✅ | 4788ms |
| Retry Behavior.Does Not Retry On 401 | ✅ | 4677ms |
| Retry Behavior.Respects Retry After Header | ✅ | 7713ms |
| Retry Behavior.Implements Backoff | ✅ | 21723ms |
| Retry Behavior.Retries On 500 | ✅ | 9352ms |
| Retry Behavior.Retries On 502 | ✅ | 5483ms |
| Retry Behavior.Retries On 504 | ✅ | 5798ms |
| Retry Behavior.Max Retries Respected | ❌ | 22044ms |
| Deduplication.Generates Unique Uuids | ✅ | 3293ms |
| Deduplication.Preserves Uuid On Retry | ✅ | 9270ms |
| Deduplication.Preserves Uuid And Timestamp On Retry | ✅ | 16795ms |
| Deduplication.Preserves Uuid And Timestamp On Batch Retry | ✅ | 7800ms |
| Deduplication.No Duplicate Events In Batch | ✅ | 3015ms |
| Deduplication.Different Events Have Different Uuids | ✅ | 3011ms |
| Compression.Sends Gzip When Enabled | ✅ | 2714ms |
| Batch Format.Uses Proper Batch Structure | ✅ | 418ms |
| Batch Format.Flush With No Events Sends Nothing | ✅ | 331ms |
| Batch Format.Multiple Events Batched Together | ✅ | 2847ms |
| Error Handling.Does Not Retry On 403 | ✅ | 4785ms |
| Error Handling.Does Not Retry On 413 | ✅ | 4712ms |
| Error Handling.Retries On 408 | ✅ | 9296ms |
Failures
retry_behavior.max_retries_respected
Expected 4 requests, got 6
Feature_Flags Tests
✅ 16/16 tests passed
View Details
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ✅ | 2972ms |
| Request Payload.Flags Request Uses V2 Query Param | ✅ | 2789ms |
| Request Payload.Flags Request Hits Flags Path Not Decide | ✅ | 2919ms |
| Request Payload.Flags Request Omits Authorization Header | ✅ | 2831ms |
| Request Payload.Token In Flags Body Matches Init | ✅ | 2983ms |
| Request Payload.Groups Round Trip | ✅ | 2845ms |
| Request Payload.Groups Default To Empty Object | ✅ | 2988ms |
| Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It | ✅ | 2884ms |
| Request Payload.Disable Geoip False Propagates As Geoip Disable False | ✅ | 2976ms |
| Request Payload.Disable Geoip Omitted Defaults To False | ✅ | 2889ms |
| Request Payload.Flag Keys To Evaluate Contains Only Requested Key | ✅ | 2881ms |
| Request Lifecycle.No Flags Request On Init Alone | ✅ | 109ms |
| Request Lifecycle.No Flags Request On Normal Capture | ✅ | 2926ms |
| Request Lifecycle.Two Flag Calls Produce Two Remote Requests | ✅ | 6384ms |
| Request Lifecycle.Mock Response Value Is Returned To Caller | ✅ | 3002ms |
| Side Effect Events.Get Feature Flag Captures Feature Flag Called Event | ✅ | 3089ms |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
turnipdabeets
force-pushed
the
chore/v4-stale-text
branch
from
October 6, 2026 13:44
6e0660c to
99a06bd
Compare
turnipdabeets
changed the base branch from
chore/v4-raise-apple-platform-minimums
to
chore/v4-remove-deprecated
October 6, 2026 13:44
turnipdabeets
marked this pull request as ready for review
October 6, 2026 13:57
dustinbyrne
approved these changes
Oct 6, 2026
turnipdabeets
merged commit Oct 6, 2026
e1cc8cf
into
chore/v4-remove-deprecated
47 of 71 checks passed
turnipdabeets
added a commit
that referenced
this pull request
Oct 7, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
turnipdabeets
added a commit
that referenced
this pull request
Oct 9, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Part of the 4.0 stack, on top of #873. This updates text and internal names that #873's changes (iOS 15 minimum, Swift tools 6.2,
apiKeyremoval) left stale. No behavior change.@available(..., unavailable)messages onPostHogConfig.surveysandsurveysConfignow say "Surveys are only available on iOS". The "15+" is redundant now that iOS 15 is the minimum.PostHogEvent.apiKey→projectToken: the internal property andinitlabel now use the public name. The wire field staysapi_key, which is what the server expects.sdk_compliance_adapter: the README andrun_tests.shnow require Swift 6.2+, to match the SDK'sswift-tools-version:6.2.apiKey/api_keythat stays"api_key"in event, batch, flags and snapshot JSONPostHogConfig.projectTokendoc: "formerly namedapiKey"scripts/downgrade-compatibility-smokePostHogConfig(apiKey:)sdk_compliance_adapterapi_keyPOSTHOG_PROJECT_API_KEYinrelease.ymlLeft alone on purpose
s.swift_versions = "5.3"in the podspec. That's the Swift language mode, which is still 5 (swiftLanguageModes: [.v5]).watchOS 9.0clause inPostHogContext's$localecheck. It only becomes redundant with chore!: raise minimum macOS to 11, tvOS to 15 and watchOS to 10 #906's watchOS 10 minimum.sdk_compliance_adapter/Dockerfilestill usesswift:5.9images. That can't resolve a 6.2-tools package, but changing it is a functional change I haven't verified with Docker, so it's left for a follow-up.💚 How did you test it?
xcodebuild buildfor iOS and watchOS succeeds.make test(macOS): all 169 XCTest tests pass. Swift Testing has 13 issues inPostHogStorageapp-group tests, which fail the same way on the base branch (macOS blocks access to the app-group container on my machine). One run also failedre-registering a different token after delivery sends again, which passed 5 times out of 5 when run on its own.📝 Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
🤖 Generated with Claude Code