Repository navigation
chore!: rename getFeatureFlagResult sendEvent to sendFeatureFlagEvent - #647
Merged
turnipdabeets merged 1 commit intoOct 7, 2026
Merged
Conversation
Matches PostHogConfig.sendFeatureFlagEvent and the iOS/Android getFeatureFlagResult parameter. The method-channel key stays 'sendEvent'. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
posthog-flutter Compliance ReportDate: 2026-10-07 15:57:55 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
dustinbyrne
approved these changes
Oct 7, 2026
turnipdabeets
added a commit
that referenced
this pull request
Oct 7, 2026
…#647) Matches PostHogConfig.sendFeatureFlagEvent and the iOS/Android getFeatureFlagResult parameter. The method-channel key stays 'sendEvent'. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
5 tasks done
turnipdabeets
added a commit
that referenced
this pull request
Oct 8, 2026
…#647) Matches PostHogConfig.sendFeatureFlagEvent and the iOS/Android getFeatureFlagResult parameter. The method-channel key stays 'sendEvent'. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Stacked on #637 (v6).
v6 renames the config option
sendFeatureFlagEventstosendFeatureFlagEvent(#636 / #638), but the per-call parameter ongetFeatureFlagResultis stillsendEvent, so one concept has two names. This renames it so everything matches:PostHogConfig.sendFeatureFlagEvent(Flutter)getFeatureFlagResult(_ key:, sendFeatureFlagEvent:)getFeatureFlagResult(key, sendFeatureFlagEvent: Boolean?)v6 users already have to touch this setting for the config rename, so this is a hard rename in the major with no deprecation shim.
Migration:
The parameter is also renamed on
PosthogFlutterPlatformInterface.getFeatureFlagResultand its IO/web implementations (v6 is breaking for platform implementers anyway, same as #645).Wire key: the method-channel argument key stays
'sendEvent'. Renaming it would touch the Kotlin and Swift plugins and the web handler for no user-facing benefit, the same choice as #645.The
getFeatureFlagPayloadremoval note in the #637 changeset now points tosendFeatureFlagEvent: false, so the v6 changelog doesn't recommend a name it also removes.💚 How did you test it?
flutter analyze: no issuesflutter test: all 781 tests pass (existinggetFeatureFlagResulttests updated to the new name; the IO tests still assert the'sendEvent'wire key)dart format --set-exit-if-changed: cleanscripts/check-api-dart.sh --update:api/posthog_flutter.api.jsonregenerated (3 param renames)📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Written with Claude Code. Dart-only rename. Native plugins and the web handler are unchanged because the wire key is kept.
🤖 Generated with Claude Code