Repository navigation
fix(flags): load shared definitions without a secret key - #851
Open
dustinbyrne wants to merge 2 commits into
Open
dustinbyrne wants to merge 2 commits into
dustinbyrne wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Like PostHog/posthog-python#1039, a worker consuming shared feature flag definitions should not need a privileged secret key. Existing initialization gates prevent that supported cache-consumer configuration from evaluating flags locally.
Changes
Cache-only readers bypass the shared loader specification's decision-first provider step; credentialed consumers retain that step.
Only posthog-server changes. Provider-only setups still require
.localEvaluation(true); the provider setter retains the existing explicit opt-in. Android/client-core defaults and behavior are unchanged.💚 How did you test it?
./gradlew :posthog-server:test spotlessCheck :posthog-server:lint :posthog-server:apiCheck: passed.Release scope
Patch release for posthog-server. Existing signatures, capture defaults and wire formats are unchanged.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi worker agents and reviewed by separate fresh-context Pi reviewers. A simplify pass covered the scoped source/tests/docs before final local validation. Human review remains required.