Skip to content

fix: include distinct_id on $identify properties - #838

Closed
o-mid wants to merge 1 commit into
PostHog:mainfrom
o-mid:fix/identify-distinct-id-property
Closed

o-mid wants to merge 1 commit into
PostHog:mainfrom
o-mid:fix/identify-distinct-id-property

Conversation

@o-mid

@o-mid o-mid commented Oct 4, 2026

Copy link
Copy Markdown

💡 Motivation and Context

Android $identify events exposed distinct_id only on the envelope, while iOS also duplicates it in properties (#272). Dashboards that key off properties.distinct_id were inconsistent across platforms.

💚 How did you test it?

  • :posthog:test — PostHogTest.captures an identify event (local Gradle blocked on missing AGP 8.9.1 here; rely on CI).

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

Made with Cursor

Align Android identify payloads with iOS so dashboards and tools that read properties.distinct_id behave consistently.
@o-mid
o-mid requested a review from a team as a code owner October 4, 2026 09:03
@o-mid

o-mid commented Oct 4, 2026

Copy link
Copy Markdown
Author

CI note: Build & Test / Lint / Changeset hygiene runs are showing action_required on this fork PR (same as other external contributions). A maintainer needs to approve workflow execution on the PR before we get a real green/red signal. Wiz scans already passed.

@marandaneto

Copy link
Copy Markdown
Member

#272 (comment)

@marandaneto marandaneto closed this Oct 5, 2026
@marandaneto

Copy link
Copy Markdown
Member

the event already has distinct id, no need to dupe in the props map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants