Name the existing Trino API cell legacy - #1161
Merged
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
bill-ph
approved these changes
Sep 8, 2026
bill-ph
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the current head and Trino API identity changes. The alias is confined to public API views while persisted ownership IDs and connection readiness continue to use the stored ID; focused regression coverage and all completed required checks pass. No P0 blockers requiring code changes found. Remaining end-to-end lanes are still pending.
— Robo Bill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
legacy.This is a naming/compatibility change only. It adds no cell registry, selection endpoint, tenant migration, or database migration. The general org endpoint continues to expose the original
trino.trino_cell_id; unassigned and foreign-cell rows keep their existing values.Validation
just test-controlplane-k8swith a disposable local PostgreSQL fixture.just lint(0 issues).just ui-test(26 files, 186 tests, typecheck and production build).sh -n tests/mw-dev/e2e/trino.shandgit diff --check.legacyAPI labels and unchanged persisted ownership. Their live execution is left to normal PR CI; no existing tenant or deployed configuration was changed manually.Compatibility and recovery
API consumers displaying the previous cell ID now receive
legacyfor the existing deployment. Do not change stored IDs orDUCKGRES_TRINO_CELL_IDto match this display name. Roll back the application version if a consumer requires the previous displayed ID.