Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix(code): preserve zoom across window state changes - #3413

Merged
richardsolomou merged 2 commits into
mainfrom
posthog-code/fix-zoom-persistence
Jul 14, 2026
Merged

richardsolomou merged 2 commits into
mainfrom
posthog-code/fix-zoom-persistence

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 14, 2026 •

Copy link
Copy Markdown
Member

Problem

Chromium resets zoom during window transitions, while native wheel updates settle asynchronously.

Changes

Persist settled native zoom before running queued menu adjustments or restores.

How did you test this?

  • Ran pnpm exec biome check on the changed zoom files.
  • Ran seven zoom tests and pnpm --filter code typecheck.
  • Verified reset, zoom, reload persistence, and restore through the native View menu.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

Restore persisted zoom after Chromium resets the active web contents during reloads and native window transitions.

Generated-By: PostHog Code
Task-Id: 55b538f3-c008-4183-8511-9a87ea17a137
@trunk-io

trunk-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

github-actions Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 6a93c1b.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(code): preserve zoom across window s..." | Re-trigger Greptile

Comment thread apps/code/src/main/zoom.ts Outdated
Comment thread apps/code/src/main/zoom.ts
Queue menu adjustments and restores until native zoom persistence has captured Chromium's settled level.

Generated-By: PostHog Code
Task-Id: 55b538f3-c008-4183-8511-9a87ea17a137
@richardsolomou
richardsolomou requested a review from a team July 14, 2026 08:08
@richardsolomou
richardsolomou merged commit f118d10 into main Jul 14, 2026
26 checks passed
@richardsolomou
richardsolomou deleted the posthog-code/fix-zoom-persistence branch July 14, 2026 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants