fix: preserve TimeSeries defaults with parser v1.0.1 - #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
github.com/orian/clickhouse-sql-parsertov1.0.1and normalize the known default TimeSeries target suffix before parsing. The new parser accepts engine-only targets, bypassing the old parse-error fallback and causing introspection to reject otherwise supported SHOW CREATE output. Normalizing first preserves the existing representation of auto-generated defaults without schema drift.Extend regression coverage to verify escaped tag mappings, absent default targets, no drift against the equivalent bare declaration, and rejection of unsupported custom targets rather than silently discarding them.
Closes #246.
Validation:
go test ./internal/... ./cmd/... ./testgo mod verifygo vet ./...git diff --checkLive ClickHouse tests were not run.