Skip to content

feat(perps): add id to funding payment records - #256

Merged
kartojal merged 1 commit into
mainfrom
feature/dev-451-support-funding-record-id-in-sdks-and-docs
Aug 6, 2026
Merged

feat(perps): add id to funding payment records#256
kartojal merged 1 commit into
mainfrom
feature/dev-451-support-funding-record-id-in-sdks-and-docs

Conversation

@kartojal

@kartojal kartojal commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Add a required id (PerpsFundingPaymentId NewType) to PerpsFundingPayment, covering both funding history and the realtime funding stream. (DEV-451)


Note

Medium Risk
The PerpsFundingPayment schema change is breaking for callers or fixtures missing id, though it matches the API and stays within experimental perps models.

Overview
Adds a required id on PerpsFundingPayment, typed as the new PerpsFundingPaymentId NewType, and re-exports that type from the perps and top-level model packages.

Funding history from list_funding_payments and realtime PerpsFundingEvent session frames now parse and surface the server record id (including compact wire keys in tests). Unit coverage was extended for REST pagination, model alias parsing, and the funding channel event payload.

Reviewed by Cursor Bugbot for commit bf2f0d3. Bugbot is set up for automated code reviews on this repo. Configure here.

@kartojal
kartojal marked this pull request as ready for review August 6, 2026 14:50
@kartojal
kartojal merged commit 3187d48 into main Aug 6, 2026
7 checks passed
@kartojal
kartojal deleted the feature/dev-451-support-funding-record-id-in-sdks-and-docs branch August 6, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants