feat(perps): add id to funding payment records - #256
Merged
kartojal merged 1 commit intoAug 6, 2026
Conversation
kartojal
marked this pull request as ready for review
August 6, 2026 14:50
cesarenaldi
approved these changes
Aug 6, 2026
kartojal
deleted the
feature/dev-451-support-funding-record-id-in-sdks-and-docs
branch
August 6, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a required
id(PerpsFundingPaymentIdNewType) toPerpsFundingPayment, covering both funding history and the realtime funding stream. (DEV-451)Note
Medium Risk
The
PerpsFundingPaymentschema change is breaking for callers or fixtures missingid, though it matches the API and stays within experimental perps models.Overview
Adds a required
idonPerpsFundingPayment, typed as the newPerpsFundingPaymentIdNewType, and re-exports that type from the perps and top-level model packages.Funding history from
list_funding_paymentsand realtimePerpsFundingEventsession frames now parse and surface the server record id (including compact wire keys in tests). Unit coverage was extended for REST pagination, model alias parsing, and thefundingchannel event payload.Reviewed by Cursor Bugbot for commit bf2f0d3. Bugbot is set up for automated code reviews on this repo. Configure here.