Repository navigation
Update the Mississippi HSA test for joint-column combination (main is red) - #9992
Merged
Merged
Conversation
#9865 (HSA deduction from the account holder) and #9885 (combine a negative Mississippi joint column with the other column) each passed alone; together the head's AGI column is -2,000 rather than floored at 0, and the joint tax combines it, so the whole deduction is used. Main has failed this case since #9865 landed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
US + core hub merge audit, us#9992 at
|
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main has failed one Mississippi test since #9865 merged:
#9865 (subtract the HSA deduction once, from the account holder) and #9885 (combine a negative Mississippi joint column with the other column) each passed CI on their own. #9885 landed first and removed the zero floor on the head's and spouse's
ms_agi. A negative column now stays negative, andms_income_tax_before_credits_jointcombines it with the other column, per Form 80-100 line 17. #9865's test still expected the old floor ("2,000 of the deduction goes unused").The bisect is on current main:
d5e8301b9c;b7aaf015cf, and at every later main commit.This PR changes the test only, not the model:
ms_agibecomes[-2_000, 50_000].ms_income_tax_before_credits_unitis 941.60: combined Column A taxable income is 1,000 + 33,400 − 3,000 = 31,400, and (31,400 − 10,000) × 4.4% = 941.60. Without the HSA, the tax is 1,029.60. All $3,000 of the deduction reduces combined taxable income.Tests
ms_health_savings_account_adjustment.yaml: 9 passed. Before this change, 1 failed and 8 passed on main.Impact
No model output change: only a test file and a changelog fragment change.
axiom: n/a
🤖 Generated with Claude Code