Skip to content

Update the Mississippi HSA test for joint-column combination (main is red) - #9992

Merged
MaxGhenis merged 1 commit into
mainfrom
fix-ms-hsa-test-after-joint-combination
Oct 7, 2026
Merged

MaxGhenis merged 1 commit into
mainfrom
fix-ms-hsa-test-after-joint-combination

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

Summary

Main has failed one Mississippi test since #9865 merged:

ms_health_savings_account_adjustment.yaml
  'Without per-person amounts the head takes the deduction, even above the head's own income':
  ms_agi@2025: [-2000. 50000.] differs from [0. 50000.]

#9865 (subtract the HSA deduction once, from the account holder) and #9885 (combine a negative Mississippi joint column with the other column) each passed CI on their own. #9885 landed first and removed the zero floor on the head's and spouse's ms_agi. A negative column now stays negative, and ms_income_tax_before_credits_joint combines it with the other column, per Form 80-100 line 17. #9865's test still expected the old floor ("2,000 of the deduction goes unused").

The bisect is on current main:

This PR changes the test only, not the model:

  • ms_agi becomes [-2_000, 50_000].
  • The comment now explains the column combination.
  • A new assertion pins the result of the combination. ms_income_tax_before_credits_unit is 941.60: combined Column A taxable income is 1,000 + 33,400 − 3,000 = 31,400, and (31,400 − 10,000) × 4.4% = 941.60. Without the HSA, the tax is 1,029.60. All $3,000 of the deduction reduces combined taxable income.

Tests

ms_health_savings_account_adjustment.yaml: 9 passed. Before this change, 1 failed and 8 passed on main.

Impact

No model output change: only a test file and a changelog fragment change.

axiom: n/a

🤖 Generated with Claude Code

#9865 (HSA deduction from the account holder) and #9885 (combine a negative
Mississippi joint column with the other column) each passed alone; together
the head's AGI column is -2,000 rather than floored at 0, and the joint tax
combines it, so the whole deduction is used. Main has failed this case since
#9865 landed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis
MaxGhenis merged commit b70cf9d into main Oct 7, 2026
35 checks passed
@MaxGhenis
MaxGhenis deleted the fix-ms-hsa-test-after-joint-combination branch October 7, 2026 17:26
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

US + core hub merge audit, us#9992 at 03e40e08b7 (squash). This fixes a red main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant