Skip to content

Remove stray PROGRESS.md working log from the repo root - #9846

Merged
MaxGhenis merged 1 commit into
mainfrom
remove-stray-progress-md
Oct 7, 2026
Merged

MaxGhenis merged 1 commit into
mainfrom
remove-stray-progress-md

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

Summary

Deletes PROGRESS.md from the repository root. It is a working log titled "Second-pass review work on #9467", and its own text says it is "Removed before the branch is handed back." It was merged by mistake.

Provenance

Checks

  • git grep -n PROGRESS.md returns no matches.
  • MANIFEST.in is recursive-include policyengine_us *. The hatch wheel target packages only policyengine_us, and no workflow or Makefile target reads the file.
  • A local uv build --sdist on this branch shows the sdist includes every root-level tracked file. This change therefore also drops PROGRESS.md from the sdist. The wheel is unchanged.
  • ruff format --check . at the locked ruff (0.15.5) passes.
  • Changelog fragment: changelog.d/remove-stray-progress-md.fixed.md (patch).

Microsimulation impact

None: no code or data change.

axiom: n/a: repository housekeeping, no policy change

🤖 Generated with Claude Code

PROGRESS.md was the working log for the second-pass review of #9467
("Second-pass review work on #9467"). Its own text says it is "Removed
before the branch is handed back", but the last commit that touched it
(0925187, "Record second-pass verification results", 2026-09-14) left
it in place, and it reached main with the #9467 merge (5115fb8).

Nothing references the file: git grep finds no mention, MANIFEST.in and
the hatch wheel config include only policyengine_us, and no workflow or
Makefile target reads it. No code or data change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DTrim99

DTrim99 commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

PR Review: Remove stray PROGRESS.md working log from the repo root

PR #9846 (author: MaxGhenis, head fb957d4596).

Summary

The PR deletes PROGRESS.md from the repository root and adds a fixed changelog fragment. It changes no code, parameters, tests or data. The file is the agent working log for the second-pass review of #9467. Its own text says it is "Removed before the branch is handed back", but it reached main with the #9467 merge. Nothing in the repo references the file, so deleting it is safe. CI is green and the branch merges cleanly. The one suggestion is an optional guard against recurrence. This is a housekeeping PR, so no source documents were collected.

Critical (must fix)

None.

Should address

None.

Suggestions

  1. Optional: guard against the log coming back.
    • Where: .gitignore:67-68 (the "Claude Code temporary files" block), or CLAUDE.md / AGENTS.md.
    • Why: this was not a one-off slip. On the Unify the SPM isolation, CPUC and dataset guard fixes #9467 branch the log was started (437394de07), removed (646bd95e58, "Remove the working progress log"), started again (e18473fa0a) and last updated (09251870f5), and then merged. Today neither .gitignore nor CLAUDE.md/AGENTS.md says anything about agent working logs, and the PR adds no guard.
    • Fix (any one):
      • Add /PROGRESS.md under # Claude Code temporary files in .gitignore.
      • Or add a one-line rule to CLAUDE.md: keep agent working logs out of the tracked tree.
    • Caveat: if the rollout workflow commits the log on purpose so that it survives across sessions, a .gitignore entry will make git add refuse the file unless -f is used. In that case, a CI step that fails when a root-level PROGRESS.md exists is the safer guard. This is out of scope for a one-file cleanup and can go in a follow-up.

Verified correct

  • The file is a stray log with no references.
    • At the head, git grep -i "progress\.md" matches only the new changelog fragment.
    • On current main, the same search returns no matches.
    • A wider case-sensitive search for PROGRESS also matches only the fragment. That search covered .github/ workflows, Makefile, MANIFEST.in, pyproject.toml, docs/, docs-quarto/ and .claude/.
  • Packaging is not affected.
    • The wheel packages only policyengine_us (pyproject.toml:60-61, [tool.hatch.build.targets.wheel] packages = ["policyengine_us"]).
    • MANIFEST.in is recursive-include policyengine_us *.
    • There is no sdist target configuration. The PR body says the deletion only removes the file from the sdist, and the configuration is consistent with that.
  • The provenance in the PR body is accurate.
    • 09251870f5 ("Record second-pass verification results", 2026-09-14) is the last commit that touched the file.
    • The file reached main through 5115fb8552 (2026-09-15, "Merge pull request Unify the SPM isolation, CPUC and dataset guard fixes #9467"), which is an ancestor of main.
    • No commit on main has touched the file since then.
  • The changelog fragment is valid.
    • changelog.d/remove-stray-progress-md.fixed.md is a top-level file and matches the branch name remove-stray-progress-md. It passes the pr.yaml regex ^changelog\.d/[^/]+\.(breaking|added|changed|fixed|removed)\.md$.
    • The check-changelog job requires a fragment on every PR and has no label bypass. If no valid fragment is added, the job fails with "No valid changelog fragment found". A fragment was therefore required here.
    • fixed gives a patch bump (.github/bump_version.py infer_bump). Choosing removed would have forced a minor bump for a file that is not in the package. Of the patch types, fixed (or changed) is the right choice.
  • The PR is scoped to the two files: a 32-line deletion and a 1-line fragment.

Out of scope (pre-existing, not counted)

  • test.py at the repo root is another stale root-level script. It fetches PRs to branch="master", which upstream no longer has, and nothing references it. It could go in a later cleanup PR. It does not affect this PR.

Axiom line assessment

axiom: n/a: repository housekeeping, no policy change is valid. The PR touches no variable, parameter, formula or test. It only deletes a non-package Markdown log and adds a changelog fragment, so the provision-parity rule does not apply.

CI status

All 35 checks pass (gh pr checks 9846), including "Check changelog fragment" and "Lint". GitHub reports the PR as MERGEABLE. The BLOCKED merge state comes only from the required review.

Branch status

The branch is 1 commit ahead of main and 37 behind. git merge-tree --write-tree PolicyEngine/main fb957d4596 exits 0 with no conflicts. In the merged tree, PROGRESS.md is removed and the fragment is added. No rebase is needed for correctness.

Verdict: APPROVE

@DTrim99 DTrim99 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving: PROGRESS.md has no references anywhere in the repo or packaging, the changelog fragment is valid, and the axiom n/a is appropriate for housekeeping. One optional suggestion in the comment above (gitignore /PROGRESS.md so it doesn't come back).

@MaxGhenis
MaxGhenis merged commit cf4e35a into main Oct 7, 2026
35 checks passed
@MaxGhenis
MaxGhenis deleted the remove-stray-progress-md branch October 7, 2026 20:40
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

US + core hub sweep audit (2026-10-07): squash-merged #9846 as cf4e35afac477190492c6ede753f9a012514c469.

Reviewed head: fb957d45969d2a0492397f3ecd3c24afe48cb00b.
Independent approval: DTrim99, https://github.com/PolicyEngine/policyengine-us/pull/9846#issuecomment-6040530386.
Latest exact-head Pull request CI: https://github.com/PolicyEngine/policyengine-us/actions/runs/37446771255 (success).
Live gates: gh pr checks exited 0; MERGEABLE; ready; no CHANGES_REQUESTED; no unresolved Max hold; no semantic area overlap since CI base.
Merge used --match-head-commit to pin the approved head.
Merged without --admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants