Skip to content

Separate concatenated URLs in Variable reference and documentation strings #9786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGhenis merged 6 commits into from
Oct 4, 2026
Merged

Separate concatenated URLs in Variable reference and documentation strings #9786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7269711
Separate concatenated URLs in reference and documentation strings
MaxGhenis Oct 4, 2026
a407083
Split remaining multi-URL reference strings and guard them
MaxGhenis Oct 4, 2026
10d3ab0
Merge upstream/main into fix-concatenated-reference-urls
MaxGhenis Oct 4, 2026
da1d28b
Merge upstream/main into fix-concatenated-reference-urls
MaxGhenis Oct 4, 2026
4f20834
Tighten the reference URL guard per review
MaxGhenis Oct 4, 2026
a634352
Merge remote-tracking branch 'upstream/main' into fix-concatenated-re…
MaxGhenis Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fix-concatenated-reference-urls.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Separated URLs that were joined in Variable reference and documentation strings, so each reference entry is one bare URL, and added a code-health test that keeps them separate.
4 changes: 2 additions & 2 deletions policyengine_us/reforms/dc_kccatc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ class dc_kccatc(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=67"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=59"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=67",
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=59",
)
defined_for = StateCode.DC

Expand Down
4 changes: 2 additions & 2 deletions policyengine_us/reforms/dc_tax_threshold_joint_ratio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ class dc_income_tax_before_credits_joint(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=36"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=34"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=36",
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=34",
)
defined_for = StateCode.DC

Expand Down
26 changes: 13 additions & 13 deletions policyengine_us/reforms/state_dependent_exemptions/repeal_state_dependent_exemptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ class ne_exemptions(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://revenue.nebraska.gov/files/doc/tax-forms/2021/f_1040n_booklet.pdf"
"https://revenue.nebraska.gov/files/doc/2022_Ne_Individual_Income_Tax_Booklet_8-307-2022_final_5.pdf"
"https://revenue.nebraska.gov/files/doc/tax-forms/2021/f_1040n_booklet.pdf",
"https://revenue.nebraska.gov/files/doc/2022_Ne_Individual_Income_Tax_Booklet_8-307-2022_final_5.pdf",
)
defined_for = StateCode.NE

Expand Down Expand Up @@ -105,8 +105,8 @@ class ok_count_exemptions(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://oklahoma.gov/content/dam/ok/en/tax/documents/forms/individuals/past-year/2021/511-Pkt-2021.pdf"
"https://oklahoma.gov/content/dam/ok/en/tax/documents/forms/individuals/current/511-Pkt.pdf"
"https://oklahoma.gov/content/dam/ok/en/tax/documents/forms/individuals/past-year/2021/511-Pkt-2021.pdf",
"https://oklahoma.gov/content/dam/ok/en/tax/documents/forms/individuals/current/511-Pkt.pdf",
)
defined_for = StateCode.OK

Expand Down Expand Up @@ -292,8 +292,8 @@ class ia_exemption_credit(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://revenue.iowa.gov/sites/default/files/2021-12/IA6251%2841131%29.pdf"
"https://revenue.iowa.gov/sites/default/files/2023-01/IA6251%2841131%29.pdf"
"https://revenue.iowa.gov/sites/default/files/2021-12/IA6251%2841131%29.pdf",
"https://revenue.iowa.gov/sites/default/files/2023-01/IA6251%2841131%29.pdf",
)
defined_for = StateCode.IA

Expand Down Expand Up @@ -381,11 +381,11 @@ class wi_base_exemption(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://www.revenue.wi.gov/TaxForms2021/2021-Form1f.pdf"
"https://www.revenue.wi.gov/TaxForms2021/2021-Form1-Inst.pdf"
"https://www.revenue.wi.gov/TaxForms2022/2022-Form1f.pdf"
"https://www.revenue.wi.gov/TaxForms2022/2022-Form1-Inst.pdf"
"https://docs.legis.wisconsin.gov/misc/lfb/informational_papers/january_2023/0002_individual_income_tax_informational_paper_2.pdf"
"https://www.revenue.wi.gov/TaxForms2021/2021-Form1f.pdf",
"https://www.revenue.wi.gov/TaxForms2021/2021-Form1-Inst.pdf",
"https://www.revenue.wi.gov/TaxForms2022/2022-Form1f.pdf",
"https://www.revenue.wi.gov/TaxForms2022/2022-Form1-Inst.pdf",
"https://docs.legis.wisconsin.gov/misc/lfb/informational_papers/january_2023/0002_individual_income_tax_informational_paper_2.pdf",
)
defined_for = StateCode.WI

Expand Down Expand Up @@ -439,8 +439,8 @@ class ok_child_care_child_tax_credit(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://oklahoma.gov/content/dam/ok/en/tax/documents/forms/individuals/past-year/2021/511-Pkt-2021.pdf"
"https://oklahoma.gov/content/dam/ok/en/tax/documents/forms/individuals/current/511-Pkt.pdf"
"https://oklahoma.gov/content/dam/ok/en/tax/documents/forms/individuals/past-year/2021/511-Pkt-2021.pdf",
"https://oklahoma.gov/content/dam/ok/en/tax/documents/forms/individuals/current/511-Pkt.pdf",
)
defined_for = StateCode.OK

Expand Down
16 changes: 8 additions & 8 deletions policyengine_us/reforms/states/dc/property_tax/dc_property_tax_reform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ class dc_ptc(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=49"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=47"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=49",
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=47",
)
defined_for = "takes_up_dc_ptc"

Expand All @@ -35,8 +35,8 @@ class dc_ptc_eligible(Variable):
label = "DC property tax credit eligible"
definition_period = YEAR
reference = (
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=49"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=47"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=49",
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=47",
)
defined_for = StateCode.DC

Expand All @@ -52,8 +52,8 @@ class dc_ptc_income_limit(Variable):
label = "DC property tax credit income limit"
definition_period = YEAR
reference = (
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=49"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=47"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=49",
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=47",
)
defined_for = StateCode.DC

Expand All @@ -73,8 +73,8 @@ class dc_ptc_elderly_head_or_spouse_present(Variable):
label = "DC property tax credit elderly head or spouse present"
definition_period = YEAR
reference = (
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=49"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=47"
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/52926_D-40_12.21.21_Final_Rev011122.pdf#page=49",
"https://otr.cfo.dc.gov/sites/default/files/dc/sites/otr/publication/attachments/2022_D-40_Booklet_Final_blk_01_23_23_Ordc.pdf#page=47",
)
defined_for = StateCode.DC

Expand Down
24 changes: 12 additions & 12 deletions policyengine_us/reforms/states/mn/walz/mn_walz_hf1938.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ class mn_refundable_credits(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1ref_21.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1ref_22.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1ref_21.pdf",
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1ref_22.pdf",
)
defined_for = StateCode.MN

Expand All @@ -30,8 +30,8 @@ class mn_social_security_subtraction(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://www.taxformfinder.org/forms/2021/2021-minnesota-form-m1m.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1m_22.pdf"
"https://www.taxformfinder.org/forms/2021/2021-minnesota-form-m1m.pdf",
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1m_22.pdf",
)
defined_for = StateCode.MN

Expand Down Expand Up @@ -68,8 +68,8 @@ class mn_standard_deduction(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1_inst_21.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-03/m1_inst_22.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1_inst_21.pdf",
"https://www.revenue.state.mn.us/sites/default/files/2023-03/m1_inst_22.pdf",
)
defined_for = StateCode.MN

Expand All @@ -96,10 +96,10 @@ class mn_itemized_deductions(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://www.revenue.state.mn.us/sites/default/files/2021-12/m1_21_0.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1_inst_21.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2022-12/m1_22.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-03/m1_inst_22.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2021-12/m1_21_0.pdf",
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1_inst_21.pdf",
"https://www.revenue.state.mn.us/sites/default/files/2022-12/m1_22.pdf",
"https://www.revenue.state.mn.us/sites/default/files/2023-03/m1_inst_22.pdf",
)
defined_for = StateCode.MN

Expand Down Expand Up @@ -136,8 +136,8 @@ class mn_cdcc(Variable):
unit = USD
definition_period = YEAR
reference = (
"https://www.revenue.state.mn.us/sites/default/files/2023-02/m1cd_21.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1cd_22_0.pdf"
"https://www.revenue.state.mn.us/sites/default/files/2023-02/m1cd_21.pdf",
"https://www.revenue.state.mn.us/sites/default/files/2023-01/m1cd_22_0.pdf",
)
defined_for = StateCode.MN

Expand Down
Loading
Loading