Skip to content

Make Codecov's project status informational - #9777

Merged
MaxGhenis merged 3 commits into
mainfrom
codecov-project-informational
Oct 4, 2026
Merged

MaxGhenis merged 3 commits into
mainfrom
codecov-project-informational

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

Summary

This makes Codecov's project status informational. The patch status stays as the coverage gate.

Why codecov/project fails on unrelated PRs

  • The PR side is partial. The only coverage upload is in the PR workflow's Quick Feedback job (.github/workflows/pr.yaml). That job runs run_selective_tests.py --coverage, which covers only the tests selected for the files the PR changes. .coveragerc counts */variables/* only.
  • The base side is stale. No workflow uploads coverage from main.
  • Nothing sets a threshold. Before this PR the repo had no codecov.yml, so any drop fails the check.

The result is a comparison between different test selections. On #9653 (head dab3797), codecov/patch reports 100% of the diff covered. codecov/project fails at 92.82% (−7.18%) "compared to 909176a", which is the head of closed PR #9539 from 2026-09-19. The same failure holds #9609, #9698, #9764 and #9766.

Change

  • codecov.yml (new, validated with https://api.codecov.io/validate):
    • coverage.status.project.default.informational: true: the project number is still reported, but it no longer fails the check.
    • coverage.status.patch.default.target: auto: written out explicitly, so the patch check keeps its current behaviour as the gate on each PR's own changed lines.
  • Changelog fragment.

This PR does not touch model code. A real main coverage baseline would need a full-suite coverage upload on push; that is left as a possible follow-up.

axiom: n/a: CI configuration only.

🤖 Generated with Claude Code

MaxGhenis and others added 3 commits October 3, 2026 16:30
Pull requests upload coverage only from Quick Feedback's selected tests,
and main uploads none, so the project percentage compares two different
test selections. Keep the patch status as the coverage gate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis
MaxGhenis merged commit 724535a into main Oct 4, 2026
35 checks passed
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

Merged by the US + core hub on the merge gates:

  • Head: a98d81d. That is the reviewed head d8fe819 plus a merge of main (picks up Fix read-only cache tests with Core 3.32.16 #9782). The PR diff is byte-identical.
  • CI: 35/35 check runs successful on this head.
  • Independent reviews (GPT-6.1 Sol): r1 found no configuration defect (approval withheld only for network); r2 APPROVE on d8fe819; r3 main-merge APPROVE on a98d81d. Reports: ~/reviews/us-hub/lander/9777-review-r1.md, -r2.md, -r3.md.
  • Max: "sure" in chat, 2026-10-03, to opening this fix.
  • Admin merge: used only for the required-review rule, at the reviewed head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant