Repository navigation
Conversation
This was referenced Sep 14, 2026
MaxGhenis
added a commit
that referenced
this pull request
Sep 15, 2026
The review's F4. `docs/spm.md` said the published wheel requires exactly `spm-calculator==1.0.0`; `pyproject.toml` requires `>=1.0.0,<=1.0.0.post1`, the range #9466 opened so a pinned development consumer resolves either version, with `uv.lock` pinning 1.0.0. `.github/release-lock.md` said the country lock was intentionally blocked until `spm-calculator==1.0.0` reached PyPI. It reached PyPI on 2026-09-11 and the committed lock has resolved it from `https://pypi.org/simple` with sdist and wheel hashes since; the committed-lock check passes. That passage now says so, and records that the guard validates sources, URLs and hashes and never a version string - `.github/release_lock.py` contains no calculator reference, so nothing there enforces the requirement `pyproject.toml` and review enforce. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #9467, which carried this work to main (see its provenance table). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9465
An explicitly requested
spm-calculator==1.0.0.post1conflicts with the country's unconditional==1.0.0requirement. Admit>=1.0.0,<=1.0.0.post1so either version can resolve. Keep the default calculator lock at 1.0.0; all 147 nonroot lock records remain unchanged.This three-file change covers package metadata only. It does not include #9462, change wrapper bundle pins, or certify a data release. Development consumers of unpublished calculator fixes must still use an immutable source revision rather than a version label alone.
Validation:
bcf45768003bb79addfafb0e6d9c7d2d5e547d9dfrom Preserve parent links and foster age limits in SPM unit assembly spm-calculator#45. Ordinary installation and dependency checking pass without an override. Runtime origins and the full package freeze were stable across the valid test runs.make format, Ruff checks, and the committed registry-lock guard pass. Independent review of the committed three-file diff found no actionable issues.The initial local test run overlapped an environment sync and was discarded; the counts above are from the restored, complete reruns. No native population data was used. This remains a draft; managed-data compatibility and the separate #9462 CI failures are not resolved by this dependency change.