Repository navigation
Conversation
…income A Wisconsin homestead household is the claimant and the claimant's spouse (Wis. Stat. 71.52(4)); Schedule H tells claimants to leave out children's social security and SSI. wi_homestead_income summed the nontaxable sources over every tax unit member, and wi_homestead_eligible counted a dependent's earnings toward the earned income test. Sum only the head and spouse with tax_unit_non_dep_add. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d tests tax_exempt_social_security is a tax-unit amount that includes dependents' benefits, so the homestead list now takes filer_tax_exempt_social_security. New cases from the 2024 Schedule H instructions: a grandchild's survivor benefits (Case 6, credit Case 5), a child's SSI and 2020 excluded UC (Case 7), and the earned income test (eligibility Cases 8-9). Four fail on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10191 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 76 76
Branches 2 1 -1
=========================================
Hits 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… eligibility Wis. Stat. 71.52(4) limits the household to the claimant and spouse: - wi_homestead_disqualified_losses adds back filer_loss_limited_net_capital_gains, so a dependent's gains and losses no longer move household income. - wi_homestead_property_tax counts only the head's and spouse's property taxes (71.52(7)) and rent (71.52(8)). - wi_homestead_eligible tests each of the head and spouse as the claimant: 18 or older, and 62 or older, disabled or with their own earned income (71.52(1g); 2024 Schedule H instructions, pages 4 and 10). Summed earnings let a spouse's self-employment loss cancel the other's wages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hand-off to the US + core hubHead: Review. The Codex review lanes were held until 06:00Z and the Claude lanes were closed, so per the fallback rule an independent in-session Opus 5.5 reviewer reviewed this PR:
The verdict file is Passed locally:
10 of the 11 new cases fail on CI. It is running on Impact. One item is still owed, and the hub is asked to run it. In the body, 2024 is at When the Disk manager reports more than 60 GB free:
In 2024 the round 2 fixes moved no credit record, so I expect 2026 to be close to the earlier +35.9M. That is a guess; it has not been run. Order. This PR is independent of #10187 and #10175. Merge. The PR needs an approving review (REVIEW_REQUIRED), so land it on the gates with Axiom. TheAxiomFoundation/rulespec-us#1726 is queued. Follow-ups. Other states' credit income lists still count dependents' Social Security through |
PR Review: Leave dependents' income out of Wisconsin homestead credit household incomePR #10191 (author: MaxGhenis, head SummaryThe PR applies Wis. Stat. § 71.52(4), under which the homestead credit "household" is the claimant and spouse, to four variables:
The policy is right:
One should-fix item remains: no test covers the spouse side of the new head/spouse logic. I removed the spouse's earned-income and age-62 paths and restricted household income to the head, and every WI test still passed. There are also five suggestions. Critical (must fix)None. Should address1. No test covers the spouse side of the new head/spouse logic.
Suggestions1. Bring rulespec-us#1726 up to the PR's current scope.
2. Cite the eligibility statute and correct two test comments.
3. Document that a dependent aged 62 or older can file their own claim, which PolicyEngine does not model.
4. Negative net Social Security now floors at zero.
5. Pre-existing, outside this diff: S corporation income counts as earned income.
Verified correct
Axiom line assessmentValid
CI statusAll 28 checks pass (
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
The law supports the change: under Wis. Stat. 71.52(4) the household is the claimant and spouse, Tax 14.03(5)(a)6 excludes children's SS and SSI, and the Schedule H instructions agree. All 21 new expectations check by hand. One should item (see the comment above): nothing tests the spouse side. Removing the spouse's earnings and age-62 eligibility paths, and summing income for the head only, leaves all 76 WI cases passing. Add three cases: only the spouse earns (eligible), only the spouse is 65 (eligible), and spouse SS 4,000 + SSI 1,000 giving household income 17,000.
What was wrong
A Wisconsin homestead credit household is "a claimant and an individual related to the claimant as husband or wife" (Wis. Stat. 71.52(4)). Household income is "all income received by all persons of a household" (71.52(5)), less $500 for each dependent. The 2024 Schedule H instructions add two points:
PolicyEngine got two things wrong:
tax_exempt_social_security, is a tax-unit amount built fromtax_unit_social_security, which includes dependents' benefits.wi_homestead_eligiblecounted a dependent's earnings toward the earned income test. The instructions say "Only one spouse must have earned income to qualify for the homestead credit. The spouse that meets this definition must be the claimant" (file page 10).Engine output on
main:mainwi_homestead_incomewi_homestead_eligiblewi_homestead_creditwi_homestead_incomewi_homestead_eligibleWhat changes
All of these follow from Wis. Stat. 71.52(4): the household is the claimant and the claimant's spouse.
wi_homestead_incomeadds the sources withtax_unit_non_dep_add, so only the head's and spouse's person-level amounts count.tanfis the W-2 payment the claimant receives, an SPM unit amount, and is added as before.filer_tax_exempt_social_security, the existing head-and-spouse version oftax_exempt_social_security.wi_homestead_disqualified_lossesadds backfiler_loss_limited_net_capital_gains(Schedule 4 line 3). A dependent's gains and losses no longer move household income.wi_homestead_property_taxcounts only the head's and spouse's property taxes (71.52(7): a homestead "owned by the claimant or a member of the claimant's household") and rent (71.52(8): "paid … by a claimant and his or her household").wi_homestead_eligibletests each of the head and spouse as the claimant. The claimant must be 18 or older, and also 62 or older, disabled, or have their own earned income (71.52(1g); 2024 instructions, file pages 4 and 10). Before, the code summed every member's earnings and split the age and earnings tests across people:Invariants
wi_homestead_income,wi_homestead_property_taxand the claimant's eligibility unchanged. The one exception is the dependent's effect on W-2 (TANF) eligibility, which counts the family's income.tax_unit_social_security_for_taxabilityfloors at zero;How it was checked
All-state household sweep, TY2020–2026. It is the same sweep as Leave dependents' unemployment compensation off California, Rhode Island and Wisconsin filer returns #10187, with a 17-year-old dependent who has UC 10,000 or survivor benefits 12,000. With this PR merged on top of Leave dependents' unemployment compensation off California, Rhode Island and Wisconsin filer returns #10187, Fix the 2020 unemployment compensation exclusion: cutoff test, per-spouse cap, dependents #10175 and Leave dependents' capital income out of state lines on the filers' return #9894/Leave dependents' own items out of DC, Delaware and Ohio subtractions #9939, every Wisconsin homestead credit decrease caused by the child's Social Security, SSI or 2020 UC goes away. That is 18 rows across 2020–2026.
The rows that remain are for a 15,000 earner whose family loses W-2 (Wisconsin Works) when the child's income counts. W-2 is the claimant's household income (Tax 14.03(4)(b)3.b), so losing it raises the credit. Results:
~/reviews/dependent-uc-state-lines-2026-10-12/movers_after_wi.txt.Tests. New cases come from the 2024 Schedule H:
wi_homestead_incomeCases 6–7;wi_homestead_eligibleCases 8–9;wi_homestead_creditCase 5.4 fail on
mainand pass here, and the WI integration and income tax files pass. Round 2 adds 6 more cases:wi_homestead_incomeCases 8–9;wi_homestead_property_taxCases 2–3;wi_homestead_eligibleCases 10–11.All 6 fail on
main. Cases 10 and 11 also fail under the round 1 code. The credit case asserts the continuous formula's 82.88. Schedule H's Tables A and B round to bands and give 84, as for the existing credit tests.Hub microsimulation impact (current head)
This is a real microsimulation on the default dataset, comparing
mainat the merge basede3815f4ccwith this PR. The runs went one at a time under the shared heavy-job lock, and the sums are weighted.a576e21681. Commits since then change only tests and the changelog.4c0b18e1f1, before the round 2 fixes to capital losses, property tax and rent, and eligibility. The 2026 re-run at the current formulas started, but I withdrew it before its PR side under the host disk pause (relayed by Fleet ops at 03:07Z). It will replace this column when the pause lifts.4c0b18e1f1)wi_homestead_incomewi_homestead_eligiblewi_homestead_creditwi_homestead_property_taxwi_homestead_disqualified_losseswi_refundable_creditswi_income_taxfiler_tax_exempt_social_securitystate_income_taxincome_taxhousehold_net_incomehousehold_benefitsWhat the 2024 re-run shows:
4c0b18e1f1.wi_homestead_property_taxchanges for 4 records whose combined weight is about 2. These are dependents' rent or property taxes, and the credit is unchanged for all 4.wi_homestead_disqualified_losseschanges for no record.wi_homestead_eligibleturns false for 5 records. Lower household income can only add eligibility, so these come from the claimant test: the head and spouse are under 62, not disabled and without their own earnings, and the unit qualified only through a dependent's. It turns true for 1 record, whose household income fell under the limit.Comparison files are in
fixes/10191-impact/on the hub host (compare.2024.json, andprev/for the earlier head).Review
The Codex review lanes were held until 06:00Z and the Claude lanes were closed, so per the fallback rule an independent in-session Opus 5.5 reviewer reviewed
4c0b18e1f1.Round 1: REQUEST_CHANGES.
a576e21681addresses all of them. Round 2: APPROVE ata576e21681.The reviewer re-ran the round 1 probes and checked:
It also confirmed that only
wi_homestead_creditandwi_homestead_incomeread the changed variables. In round 2 it flagged that Case 11 lacked explicit head and spouse roles, so the 17-year-old was inferred as a dependent, and that the changelog was too narrow.509e5c9d71fixes both.axiom: TheAxiomFoundation/rulespec-us#1726 queued (rulespec-us us-wi has no homestead credit module; the issue is dispatch-ready with us-wi/statute/71.52 from the pinned release and companion tests from these YAML cases)
🤖 Generated with Claude Code