Repository navigation
Add New Jersey state supplementation for 2026 - #10157
Conversation
…ation - Registry placement and comments, SNAP reference title, shorter programs.yaml note - Lowercase POMS anchor; document the C couple placeholder, mixed-arrangement averaging and the ineligible-spouse limitation - Realistic ages and incomes in existing cases; couple-with-income and living-arrangement precedence tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Review: Add New Jersey state supplementation for 2026PR #10157 (author: hua7450, head SummaryThe PR adds New Jersey's federally administered optional State Supplementary Payment (SSP):
The 2026 policy content is right:
Two should-fix items remain:
Critical (must fix)None. Should address1.
2. The two rate-file descriptions don't follow the house template.
Suggestions
Verified correct
Batch checks
Axiom line assessmentInvalid (Should 1).
CI statusAll 26 checks pass (
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
The 2026 policy is correct: all 13 rate cells match POMS SI 01415.058 J.2, the living-arrangement codes match J.1, the SI 01320.430 deeming is right, and all 34 YAML cases check by hand. Two should items (see the comment above): (1) 'axiom: needed' isn't valid for a staff PR adding a program; no NJ SSP module exists in rulespec-us, so file a dispatch-ready pe-parity issue and add a queued line; (2) the individual.yaml and couple.yaml descriptions are off the template.
…ferences, add tests - Move parameters, variables and tests from nj/dhs/ssp to nj/njdhs/ssp, the existing New Jersey Department of Human Services folder. - Rate-file descriptions follow the template; references point to J.2.a and J.2.b; SI 01320.430 D stays on nj_ssp only. - Cite SI 01415.058 J.1 on the living arrangement and SSA's New Jersey program description (statutory basis N.J.S.A. 44:7-86) on nj_ssp. - Note the higher individual rate under deeming for codes B and C, and the Lifeline payment in every rate except G (issue 10230). - Integration: Case 2 is the month of entry; Case 7 asserts spm_unit_benefits; Case 8 pays congregate care spouses as individuals after entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…into nj-ssp-2026
…bled child case - Integration Case 2 pays the couple congregate care rate, which SI NY01415.025 keeps only in small household-scale facilities; the month of entry gets the couple OSS D and is not modelled. - Integration Case 6's explicit code C applies to a couple living only with a foster child. - nj_ssp Case 17: a disabled child living with parents gets code B. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Integration Case 9: a spouse earning the New Jersey cashier median and a child in the household. Below the couple FBR, deeming pays the full 31.25 individual rate, not the 25.35 couple rate (SI 01320.430 D.2.c). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, David. The fixes are in e02eacf, 61f4392 and 8aefd6c, with a merge of Should 1 (Axiom line): filed TheAxiomFoundation/rulespec-us#1771 (
The axiom line now points to it. Should 2 (descriptions): both rate files now read "New Jersey provides this amount as the monthly individual (couple) payment under the State Supplementary Payment program." Suggestion 1 (earlier years): history is out of scope for this PR, as for the other state SSP PRs, and Suggestion 2 (Texas rebate copy): filed #10226 to keep one Suggestion 3 (couple and deeming readings):
Suggestion 4 (LIHEAP and the Lifeline): filed #10230. It will make New Jersey LIHEAP count Suggestion 5 (two folders): the SSP moved to Suggestion 6 (polish):
On the merged head, these pass locally: the 37 New Jersey cases, 243 federal SSI cases, and the aggregate list integrity and program registry tests (677 passed, 10 skipped). |
PR Review (round 2): Add New Jersey state supplementation for 2026PR #10157 (author: hua7450). This round reviews head
SummaryZiming fixed both round-1 should items. The axiom line now points to rulespec-us#1771, which is open, labelled The New Hampshire bug pattern doesn't occur here. The New Jersey-gated arrangement variable masks non-residents to Round-1 findings status
New findingsCritical (must fix)None. Should addressNone. Suggestions1. Point the two remaining deferrals at their issues (optional; no change to behavior).
Verified
Axiom line assessmentValid:
CI statusAll 27 checks pass (
Branch status
Verdict: APPROVE |
DTrim99
left a comment
There was a problem hiding this comment.
Approving round 2; details in the report above. Both should items are fixed: rulespec-us#1771 is open, pe-parity and ready for the encoder (companion tests A–R mapped to cases), and both rate descriptions follow the house template. The move to nj/njdhs/ssp left nothing behind. New Cases 8, 9 (code B deeming) and 17 (disabled child) check by hand. I also checked for the NH-sibling bug (a state-gated default indexing a missing key) and it doesn't occur here: the living arrangement masks non-residents to NONE, which both rate files cover. NJ+MA, NJ+PA+NY and NJ+CA simulations run cleanly, with identical results combined vs. alone. 37 of 37 tests pass and all 27 CI checks are green. The deferrals (#10230, #10226, history) are reasonable.
What and why
New Jersey's optional SSI supplement was missing from PolicyEngine-US. Add
nj_sspwith the verified 2026 rates for each New Jersey living arrangement code, including the special rate for a recipient who lives only with an ineligible spouse.The calculation uses the shared SSI state supplement helper (
_ssi_state_supplement.py, identical to the copy in the sibling state SSP PRs). It handles the income reduction, couple halving, spouse-to-spouse deeming, SSA cent rounding and the $1 minimum. Under deeming it uses the higher individual rate, because New Jersey's individual rates exceed its couple rates in codes B and C. The supplement follows SSI eligibility and take-up, because SSA pays it with the federal benefit. Add it to household and SPM benefit totals and to SNAP and HUD unearned income.Some situations need explicit inputs:
Every rate except the Medicaid-facility rate includes New Jersey's Lifeline utility payment. #10230 tracks counting the supplement net of the Lifeline in New Jersey LIHEAP.
The files live under
gov/states/nj/njdhs/ssp, next to New Jersey's other Department of Human Services programs.References
Coverage limits
The registry marks New Jersey as partial, verified for 2026. Mandatory grandfathered supplementation is not modeled. Earlier years use parameter backfilling and are unverified historical estimates; #8764 tracks earlier rates, and no historical rate coverage is claimed.
Related: #10226 tracks the reform copies of
spm_unit_benefits(such as the Texas rebate's), which this PR leaves unchanged.Test plan
nj_ssp.yaml, 11 innj_ssp_living_arrangement.yamland 9 inintegration.yaml. They cover:spm_unit_benefitsintegration.main: the 37 New Jersey cases and 243 federal SSI cases pass locally, and the aggregate list integrity and program registry tests pass (677 passed, 10 skipped).ruff formatandgit diff --check.changelog.d/.axiom: POMS SI 01415.058 J; SI NY01415.025; SI 01320.430 D TheAxiomFoundation/rulespec-us#1771 queued