Skip to content

Drop the fixed Illinois AABD entry from the person-adds ratchet - #10092

Merged
MaxGhenis merged 1 commit into
mainfrom
fix-known-violations-il-aabd
Oct 11, 2026
Merged

MaxGhenis merged 1 commit into
mainfrom
fix-known-violations-il-aabd

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

Main's Rest suite fails policyengine_us/tests/code_health/test_no_group_variables_in_person_adds.py::test_known_violations_only_shrink:

AssertionError: No longer projected; delete these from KNOWN_VIOLATIONS:
  ('il_aabd_expense_exemption_person', 'adds', 'state_withheld_income_tax')

Two merges crossed. #9897 (merged 2026-10-10) added the ratchet with this entry listed as a known bug. #9902 (merged 2026-10-11 13:08Z) fixed the bug, making il_aabd_expense_exemption_person count only the person's own withholding, but did not remove the entry. Every PR whose CI merges current main now fails the Rest job; #10054's run 38142244518 is one.

This removes the entry. The test passes locally on this branch (10 passed) and fails on main at f403afe (1 failed, 9 passed) with the message above. Test-only change; no model output changes.

axiom: n/a: test bookkeeping, no policy change

🤖 Generated with Claude Code

#9902 made il_aabd_expense_exemption_person count only the person's own
withholding, so it no longer adds the tax-unit state_withheld_income_tax.
test_known_violations_only_shrink (#9897) then fails on main because the
entry is still listed in KNOWN_VIOLATIONS. Remove it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

Merge audit: head 404ee0c. gh pr checks exit 0 (Rest and Microsimulation suites included); mergeable; not a draft; no CHANGES_REQUESTED. Independent GPT-6.1 Sol review (Subfleet run 20261011-105243-pr10092-review): APPROVE at this head. It confirmed that #9902 removed the tax-unit source, that the test fails on main f403afe and passes here, and that the other six KNOWN_VIOLATIONS entries are still live. Admin-merged with --match-head-commit because the only block was the required approving review on a maintainer's own PR. Test-only change, no model output changes.

@MaxGhenis
MaxGhenis merged commit 065d0e9 into main Oct 11, 2026
26 checks passed
@MaxGhenis
MaxGhenis deleted the fix-known-violations-il-aabd branch October 11, 2026 19:23
MaxGhenis added a commit that referenced this pull request Oct 11, 2026
Brings in #10092, which drops main's stale il_aabd entry from the person-adds
ratchet that failed this branch's Rest job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis added a commit that referenced this pull request Oct 11, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis added a commit that referenced this pull request Oct 11, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant