Skip to content

Require fix pull requests to change a test and name their reproducer #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGhenis merged 7 commits into from
Oct 12, 2026
Merged

Require fix pull requests to change a test and name their reproducer #2325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2353d17
Require fix pull requests to change a test and name their reproducer
MaxGhenis Oct 11, 2026
9e378d9
Address the GPT-6.1 Sol review of the Fix evidence check
MaxGhenis Oct 12, 2026
4ddff4c
Merge remote-tracking branch 'origin/main' into fix-pr-evidence-check
MaxGhenis Oct 12, 2026
11059ed
Close the fix-evidence review's non-blocking findings
MaxGhenis Oct 12, 2026
2a6fc1b
Accept TestCase only from unittest; reject unittest's skip decorators
MaxGhenis Oct 12, 2026
354a1a7
Read TestCase's last binding; take only marks from pytestmark
MaxGhenis Oct 12, 2026
3de2f81
Catch aliased marks in pytestmark; read TestCase as bound at the class
MaxGhenis Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,10 @@ Fixes #
- [ ] `make format`
- [ ] Changelog fragment in `changelog.d/`

## Reproducer

<!-- Required for fix PRs: an added, modified or type-changed fragment directly in changelog.d/ whose filename has a fixed part after the first dot, or the bug/bug-fix label. Name a collectable pytest test (file.py::test_name or file.py::TestClass::test_name) or executable YAML policy test (file.yaml or file.yaml::name) in an added, modified or type-changed file. Use n/a: <reason> only if no files under policyengine_uk/ outside policyengine_uk/tests/ and neither pyproject.toml nor uv.lock are added, modified, type-changed or deleted. Separate multiple ids with commas or semicolons. -->
Reproducer: <test id>

<!-- Required for any change to policy (programmes, parameters, eligibility, bug fixes). See .github/CONTRIBUTING.md ("Axiom parity"). Keep one standard option below, or use axiom: needed if you are an external contributor who cannot complete the Axiom work; a maintainer will follow up. -->
axiom: <legal id> encoded-correct | <rulespec-uk PR> encoded | <rulespec-uk issue> queued | n/a: <reason>
Loading
Loading