Repository navigation
Conversation
5f7187f to
5f9c96b
Compare
Critical fixedImplemented all six approved additional Housing Benefit groups in this PR: historical allowance/deduction schedules; child/family/disability applicable amounts and the claimant's ESA age exception; childcare qualification and limits; special/permitted-work earnings disregards; capital exclusions/ownership and LISA medical evidence; additional non-dependant exceptions and claimant-specific postponement. Government references are embedded in parameters and variables. The description now incorporates #2196, explains the new factual inputs and timing conventions, and identifies existing PR ownership. No duplicate Pension Credit earnings formula is added: #2019 retains that correction. VerificationRebased onto main This remains draft for review and dependency composition, particularly the PC assessment, non-dependant and asset changes. Passing standalone tests does not verify every unmerged combination. New factual fields are not silently populated in datasets; coverage is documented as partial. Local audit/skill files are not included, and individual parameter audit dates are unchanged. |
Critical fixedFixed all 18 CI failures across eight existing YAML test files. Childcare fixtures now provide per-child charges/provider facts, work tests establish paid or expected-paid work, and applicable-amount/disability-disregard expectations reflect the statutory additions. Government sources determine these changes; expectations were not changed merely to accept a failing calculation. The failures also exposed a real CTR historical under-65 allowance omission. Added referenced national rates and removal dates, preserving the existing higher-age rates and keeping HB eligibility/child additions out of CTR. Added 28 regression cases, including national cutoff boundaries, unpaid work and insufficient disability facts. VerificationSequential local checks: 199 YAML + 168 Python = 367 passed. Lint, formatting and whitespace checks pass. No local full suite or broad property-test sweep was run. GitHub CI for this correction commit is pending; the PR remains draft. |
Fixes #2196
Fixes #2197
Summary
Expand the original capital-threshold correction to implement the six additional Housing Benefit gaps identified by the whole-program audit of release 2.106.1. The changes correct older allowance and deduction histories, add missing child applicable amounts, apply statutory childcare and earnings-disregard conditions, exclude qualifying retained capital, and add non-dependant exceptions and pension-age postponement. Government citations are embedded in the relevant parameters and variables, not only this description. Existing corrections owned by other PRs are preserved rather than copied.
Changes and government evidence
Connected Council Tax Reduction correction
The CI regressions exposed a missing historical personal-allowance category in the connected CTR calculation. Add separate under-65 rates and category dates for England, Scotland and Wales: England removed the category on 6 December 2018, Scotland on 1 February 2021, and Wales for annual schemes beginning 1 April 2022. England/Scotland mid-year changes use preserved Boolean schedules with
fiscal_year_segments; the Welsh provision applies by scheme year, not to five days of the preceding model year. Existing higher-age rates remain shared with HB; this does not import HB child additions or HB eligibility into CTR, or duplicate the remaining rate corrections owned by #1925.Sources: England historical table, Scotland commencement and category removal, Wales scheme-year application and replacement table. These references also appear in code and parameters.
Inputs, timing and coverage
See the assessment documentation for the input contract.
fiscal_year_segmentshandle the specified mid-year category/restriction changes.childcare_expensesalone is insufficient.Existing PRs and merge composition
This remains draft. The complete audit cannot be considered resolved until the existing corrections below are incorporated and their interactions reviewed. Issue #2196 stays open until that work and this PR are complete.
All open-PR list pages and changed-file pages were inspected for overlapping work. Standalone tests do not establish that every combination of unmerged PRs passes.
Validation
Rebased onto actual main
9f92d53e714e7f0b0381c42d82df9e4ce9ea7195.test_housing_benefit_parameter_history.py,test_housing_benefit_additional_rules.pyandtest_housing_benefit_non_dep_additional_rules.py— 168 passed in 83.16s.make formatran before committing;ruff check .,ruff format --check .andgit diff --checkpass.axiom: needed