Repository navigation
Name each benefit's LHA category and determination; drop dead UC LHA test inputs - #2134
Merged
Merged
Conversation
…inputs Follow-ups from the round-4 review of #2022: - The HB notebook named the Universal Credit category (LHA_category) for the Housing Benefit cap. It now names housing_benefit_LHA_category (HB Regs 2006 reg 13D) and housing_benefit_LHA_rate. - benunit_lha's docstring said the two benefits read one table. Housing Benefit reads the weekly determination through its own category, Universal Credit the monthly one through LHA_category. BRMA_LHA_rate's label and documentation now say it is the weekly determination read for the UC category, which no formula reads. - Four uncapped_BRMA_LHA_rate inputs in #2006's UC tests stopped mattering once uc_LHA_cap read the published monthly rates. They are replaced by an explicit brma: MAIDSTONE, and the comments cite the published rates (750 and 905 a month). Rent binds in every case, so no expected value changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the review of this PR: - test_mixed_age_couple_properties drew a BRMA_LHA_rate input that no formula reads, so Hypothesis varied nothing. It now draws the household's BRMA from four North West areas, whose published rates span a similar range (one bedroom, 2026: GBP 88.60 to 178.36 a week). - lha_published_rates.yaml pins Maidstone one-bedroom for 2025-26: VOA GBP 172.60 a week (8,975.20 a year) and DWP GBP 750 a month (9,000), the UC rate the updated fixtures cite. - Rewrap a long docstring line in housing_benefit_LHA_rate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Handed to the UK hub (only CI remains).
|
Collaborator
Author
|
Merged by the UK hub, which took this PR on handoff from local_fa32d389, under the PE-UK merge-on-gates rule.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2022 (published LHA rates): the three nonblocking findings from its round-4 review. No model output changes.
What and why
LHA_category, which since Give sharers, boarders and lodgers their own rent, tenure and LHA category #2006 is Universal Credit's category, for the Housing Benefit cap. It now nameshousing_benefit_LHA_category(HB Regulations 2006 reg 13D) andhousing_benefit_LHA_rate.benunit_lha's docstring said both benefits read one table. Housing Benefit reads the weekly determination (Rent Officers (Housing Benefit Functions) Order 1997) through its own category. Universal Credit reads the monthly one (Rent Officers (Universal Credit Functions) Order 2013) throughLHA_category(uc_LHA_cap).BRMA_LHA_rate's label and documentation now say it is the weekly determination read for the UC category. No formula reads it.uncapped_BRMA_LHA_rateinputs in Give sharers, boarders and lodgers their own rent, tenure and LHA category #2006's UC tests (rent_of_sharers_boarders_and_lodgers.yamlandhousing_benefit_meals_deduction.yaml) stopped affecting anything onceuc_LHA_capread the published monthly rates in Use published LHA determinations and apply Sch 3B paras 3 and 3A #2022. Each case now setsbrma: MAIDSTONEexplicitly, and the comments cite the published Maidstone UC rates: £750 a month (one bedroom) and £905 (two bedrooms) for 2025-26 and 2026-27. A stale comment's £11,892.40 two-bedroom rate becomes £10,860. Rent binds in every case, so no expected value changes.test_mixed_age_couple_properties.pydrew aBRMA_LHA_rateinput that no formula reads, so Hypothesis varied nothing. It now draws the household's BRMA from four North West areas, whose published rates span a similar range (one bedroom, 2026: £88.60 to £178.36 a week).lha_published_rates.yamlnow pins the £750 one-bedroom UC rate those comments cite: Maidstone one-bedroom, 2025-26 (VOA £172.60 a week; DWP £750 a month).housing_benefit_LHA_rateis rewrapped.Test plan
lha_ratesfor 2025 and 2026).policyengine-core test policyengine_uk/tests/policy -c policyengine_uk: 2,220 passed at 1200939pytest policyengine_uk/tests/test_mixed_age_couple_properties.pyruff format --checkandruff checkon the changed Python fileschangelog.d/axiom: n/a: documentation and test fixtures only; no change to policy logic
🤖 Generated with Claude Code