Repository navigation
Forward all storage arguments in the read-only cache test fixture (core 3.32.16) - #2125
Merged
Merged
Conversation
policyengine-core 3.32.16 calls InMemoryStorage.put(..., derived=...). The fixture replaced put and get with fixed signatures, so five code-health tests failed with an unexpected keyword argument on every PR, because CI installs the latest core. The fixture now forwards every argument. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Merged by the UK hub (session local_8e19f9d5, Opus 5.5) under the PE-UK merge-on-gates rule:
Follow-up, out of scope here: CI's "Install package" step should install from |
This was referenced Oct 4, 2026
MaxGhenis
added a commit
that referenced
this pull request
Oct 4, 2026
One conflict, in income_support_eligible.py. Main's #1907 rewrote the Income Support conditions: the carer limb now needs a claimant or partner who is under the qualifying age for State Pension Credit and a carer (SSCBA 1992 s.124(1)(aa) and (e), IS Regs 1987 Sch 1B para 4). That already contains this branch's rule (a claimant or partner carer, not any member), so the formula and its comments are main's. The reference tuple is the union of both sides: Sch 1B, reg 4ZA, s.124 and Claims and Payments Regs 1987 reg 4. Main also brought in a fix for the read-only cache test fixture with policyengine-core 3.32.16 (#2125), which failed this branch's last CI run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policyengine-core 3.32.16 (published 3 October 2026, 20:59Z) changed
Holderto callInMemoryStorage.put(value, period, branch_name, derived=...). Theread_only_cachefixture inpolicyengine_uk/tests/code_health/test_cached_arrays_not_written_in_place.pyreplacedputandgetwith fixed signatures, so five code-health tests fail withput() got an unexpected keyword argument 'derived'.CI's "Install package" step installs the latest core, not the version
uv.lockpins (3.32.13). So the failure hits every PR's Test job and main's "Code changes" run (first seen on #1938, run 37153291625).The fixture now forwards every argument to the original methods, so it keeps working whatever keywords core adds. Nothing outside the test changes.
Tests
pytest policyengine_uk/tests/code_health/test_cached_arrays_not_written_in_place.py:Ruff format and check are clean. No model behaviour changes, so there is no microsimulation impact.
🤖 Generated with Claude Code