You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Follow-ups from #2160: qualifying-age docstring, UC work-related groups property-file speed, changelog fragment example #2162
Three small follow-ups found while reviewing #2160. Each is outside that PR's scope.
Qualifying-age documentation. The documentation of has_attained_state_pension_credit_qualifying_age (from Use the State Pension Credit qualifying age, and start-of-year status for Class 4 NI #1907) says men born before 6 December 1953 "reach it before their own State Pension age of 65". For a man born on 6 November 1953, the qualifying age (Pensions Act 1995 Sch 4 para 1 table 1: "6th November 1953 to 5th December 1953", 6 November 2018) falls on his 65th birthday. A check of every birth date from 1880 to 5 December 1953 found that is the only date where the two coincide. Suggested wording: "reach it before their own State Pension age of 65 (on it, for a birth on 6 November 1953)". The formula is unaffected.
Property-file speed.policyengine_uk/tests/test_uc_work_related_groups_properties.py lacks the pytestmark = pytest.mark.usefixtures("cloned_uk_tax_benefit_system") used by the repo's other property files (test_ni_class_4_properties.py, test_ni_class_4_profits_properties.py, test_trading_allowance_properties.py, test_bus_fare_reforms.py, test_ni_class_4_maximum.py). So it loads the model again for every Simulation. On a loaded host, an unmodified local run reached 3 tests in 90 minutes. With the fixture applied to every test, all 14 passed in 2,035 s.
Changelog fragment example.docs/engineering/skills/github-prs.md (lines 43-48) shows a fragment that starts with - . [tool.towncrier] sets no template, so towncrier's default template adds the bullet itself, and such fragments render as - - in CHANGELOG.md. There are 94 such lines on main, including in 2.122.2 and 2.121.0. Drop the - from the example. Optionally, normalise the existing - - lines.
Three small follow-ups found while reviewing #2160. Each is outside that PR's scope.
documentationofhas_attained_state_pension_credit_qualifying_age(from Use the State Pension Credit qualifying age, and start-of-year status for Class 4 NI #1907) says men born before 6 December 1953 "reach it before their own State Pension age of 65". For a man born on 6 November 1953, the qualifying age (Pensions Act 1995 Sch 4 para 1 table 1: "6th November 1953 to 5th December 1953", 6 November 2018) falls on his 65th birthday. A check of every birth date from 1880 to 5 December 1953 found that is the only date where the two coincide. Suggested wording: "reach it before their own State Pension age of 65 (on it, for a birth on 6 November 1953)". The formula is unaffected.policyengine_uk/tests/test_uc_work_related_groups_properties.pylacks thepytestmark = pytest.mark.usefixtures("cloned_uk_tax_benefit_system")used by the repo's other property files (test_ni_class_4_properties.py,test_ni_class_4_profits_properties.py,test_trading_allowance_properties.py,test_bus_fare_reforms.py,test_ni_class_4_maximum.py). So it loads the model again for everySimulation. On a loaded host, an unmodified local run reached 3 tests in 90 minutes. With the fixture applied to every test, all 14 passed in 2,035 s.docs/engineering/skills/github-prs.md(lines 43-48) shows a fragment that starts with-.[tool.towncrier]sets no template, so towncrier's default template adds the bullet itself, and such fragments render as- -inCHANGELOG.md. There are 94 such lines on main, including in 2.122.2 and 2.121.0. Drop the-from the example. Optionally, normalise the existing- -lines.