Repository navigation
Act on the fresh review: accuracy, accessibility, and the stale Markdown copy - #4
Merged
Merged
Conversation
Wrong or misleading: - "They fall into one of five types" — plural subject, singular predicate. The Markdown had it right; the page had regressed. - "without switching tools" contradicted the section above it, which is about the model switching between 21 tools. The point is that the reader does not leave the conversation. - The worked-example chip omitted "Child Benefit" and the requested output, while stage 1 claimed to extract both from "the user's exact words" and stage 2 bound a Child Benefit parameter from wording that was not shown. - "gateway route" and "full lifecycle" rendered as code chips styled exactly like validate_reform, so they read as public tool names. They are not. - Tax revenue rising on a benefit increase reads as a sign error; say that the High Income Child Benefit Charge is why. - content/current-article.md had drifted badly: three sections missing and a different results table. Regenerated from the page, and the README no longer calls it canonical, because a hand-synced duplicate will drift again. Accessibility: - --text-light was #7a9494, 3.2:1 on white, below the 4.5:1 minimum, and it carried the results-table caveat and every card meta line. - The six stages were spans, so they could not be navigated by heading, and their sections had no accessible name. - The boundary diagram scaled its labels to about 3.5px on a phone because max-width: 100% stopped the container's overflow-x from ever engaging. - Keyboard focus on a tool chip looked identical to selection, so two chips read as active at once while tabbing. - The question panel's live region re-announced content the tab change had already announced. Also: capped the measure at 78ch (it ran to ~140 characters a line), added a publication date to a piece whose figures are version-pinned, dropped the timeline's hover affordances since it has no click handler, set lang="en-GB", and removed instructional filler and meta-commentary. Left alone deliberately: the CTA host, the absence of a UK Chat evaluation, and the gap between a deterministic gate and the model-generated plan it runs on. Those are editorial calls. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acts on a fresh independent review of the article. Mechanical and clear-cut fixes only — the editorial calls are listed at the bottom, untouched.
Wrong or misleading
gov.hmrc.child_benefit.amount.eldestfrom wording that was never shown.gateway routeandfull lifecyclerendered as<code>chips styled identically tovalidate_reformandrun_household_simulation, so they read as public tool names. They are not tools; the row is now omitted when a question kind has none.content/current-article.mdhad drifted badly — missing the PolicyBench paragraph, "The boundary", and "What you can ask" entirely, and carrying a different results table — while the README called it "the canonical editorial reference". Regenerated from the page. The README now says the page is canonical, because a hand-synced duplicate will drift again.Accessibility
--text-lightwas#7a9494, 3.2:1 on white, under the 4.5:1 minimum, and it carried the results-table sign-convention caveat plus every card meta line. Darkened at the token, which fixes six call sites at once.<span>s, so a screen-reader user could not navigate them by heading, and the sections had no accessible name. Now<h3>witharia-labelledby; the CSS already gave.step-titleits own size, so nothing moves visually.max-width: 100%prevented.agent-flow-container'soverflow-x: autofrom ever engaging. Amin-widthlets it scroll.aria-liveregion re-announced what the tab change had already announced.Also
Capped the measure at 78ch (running text was ~140 characters a line), added a publication date to a piece whose figures are pinned to a dataset release, dropped the worked-example timeline's hover affordances since it has no click handler, set
lang="en-GB", and removed instructional filler ("Explore these categories in the interactive below", "(more on those later)") and meta-commentary about the article's own structure.Deliberately not changed
policyengine-uk-chat.vercel.app.The reviewer also could not verify the article's claims about the chat service — the 30-round cap, the five gate outcomes, the SSE event types, "no generic agent framework in the request path" — against
policyengine-uk-chat, which is a separate repo. Worth checking before publication.bun run checkpasses.