Repository navigation
Conversation
A reference that cites one PDF page keeps the page only in the href (#page=57). A reference that cites several pages of one source keeps a single entry: the href opens the first cited page and the quoted title ends with "#page 72-75" or "#page 29,32-33,36,41". Updates the model-development parameters reference, the rules-engineer agent, and the implementation-validator agent so they agree. Refs PolicyEngine/policyengine-us#10008 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hua7450
marked this pull request as ready for review
October 8, 2026 02:58
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets a parameter reference title carry a page list when the reference cites several pages of one PDF. A reference that cites one page still keeps the page only in the href.
Refs PolicyEngine/policyengine-us#10008
Rule
referenceentry per source document. URLs that differ only by#page=are the same source.#page=57in the href, no page text in the title.#page 72-75(consecutive) or#page 29,32-33,36,41(nonconsecutive). The title is quoted, because an unquoted#starts a YAML comment and truncates the title.#page=1,3,5.Why
The model-development reference said "no page number in title", and the rules-engineer and implementation-validator agents said page numbers go in
href:, never intitle:. With one entry per source, a reference citing pages 72-75 could show only page 72. PolicyEngine/policyengine-us#9743 uses the page-list title, and its round 3 review pointed out that the skill guidance contradicts it; the implementation-validator would also report that title as CRITICAL.Changes
skills/policyengine-model-development/references/parameters.md: example comment and thereferencebullet.targets/claude/agents/country-models/rules-engineer.md: reference-format section, correct and forbidden examples, title and href rules, and the self-check.targets/claude/agents/country-models/implementation-validator.md: the reference-format check, and the example finding now names a one-page reference.Not included
AGENTS.mdchange, which that issue tracks.Test plan
🤖 Generated with Claude Code