Repository navigation
Conversation
policyengine-app-v2#1237 formats post dates from their calendar fields, so a bare posts.json date shows as its own day in every time zone. Drop the advice to always add a time of day; keep dates free of offsets, which the website's data test rejects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…review nit) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #94. It targets
max/report-guidance-charts-covers-grading, the only branch where the "Post dates" note exists. GitHub retargets this PR tomainwhen #94 merges.PolicyEngine/policyengine-app-v2#1237 (merged) now formats post dates from the year, month and day in the string, so a bare
posts.jsondate shows as its own day in every time zone. The note's advice to always add a time of day is therefore obsolete. The new note says:dateas text, andwebsite/src/__tests__/lib/postDate.test.tsin app-v2 fails on any date that is notYYYY-MM-DDorYYYY-MM-DD HH:MM[:SS].No version bump; #94 already carries the 4.0.3 release.
uv run pytest tests/test_no_stale_references.pypasses.🤖 Generated with Claude Code