Repository navigation
Streamline encode-policy-v2 and strengthen review handoffs - #89
Merged
Merged
Conversation
Two benchmark runs under this branch's workflow exposed one failure class: delegated contexts doing model work outside the contract. Encode workers now use a no-delegation `model-worker` profile mirroring `review-worker`; both coordinators brief owners from one shared contract block and treat the coordinator's bounded test invocation as the run of record (a worker may self-check its owned files once). Launchers gain the compatibility-stub fallback, the nested-dispatch `name` rule and Bash timeout guidance. Review adjudication forbids post-report source probing and defines the adjudication/consolidation timing overlap. Encode gains canonical progress logs and timing keys. Benchmark notes record the MO v6 interruption and the Kansas LIEAP end-to-end run. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6rihVz3MtZQKCzzkCib35
Regenerate the dashboard manifest with a PyYAML interpreter: the previous regeneration fell back to the subset parser, turning analysis numbers into strings and dropping the nested corroboration verdict; it also lacked the two worker profiles. Set the bounded test deadline to 540 seconds so it fires under the tool's 600-second maximum and the wrapper's exit status survives. Harden the model-development hook against missing cwd or malformed input and add a behavioral test. State the fallback when model-worker cannot be a retained named worker, drop Edit from review-worker, and correct the agent count in the guide. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6rihVz3MtZQKCzzkCib35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoding workflow spread routine work across many successive agents, and the MO LIHEAP benchmark exposed command-stub resolution failures, expensive review handoffs and unsupported scenarios entering the critical-fix loop. This change consolidates encoding ownership and makes the review handoff distinguish confirmed defects from unresolved claims.
Closes #87.
Changes
review-workerfor both reviewers andmodel-workerfor the encode implementer and test-author (Skill access, no Agent/Task; model-worker also has no web tools). Brief both encode owners from one shared contract block, make the coordinator's bounded test invocation the run of record with at most one worker self-check, add encode progress logs and canonical timing keys, forbid post-adjudication source probing in review, and define the adjudication/consolidation timing overlap. Launchers gain the compatibility-stub fallback, the nested-dispatchnamerule and a 540-second bounded test deadline under the tool maximum.Validation
python -m pytest --ignore=tests/test_skill_examples.py -q— 175 passed.git diff --checkpassed.The final workflow still needs a full real-PR benchmark to establish end-to-end speed and review quality. This PR does not claim a new 10–15-minute runtime. Detailed observations and limitations are recorded in
skills/review-program/references/benchmark.md. No MO model implementation, local source cache or user research notes are included.Catalog export now reports 23 skills, 36 agents, 20 command files and 8 bundles; the separately maintained app-v2 website stats need the corresponding companion update.