Repository navigation
Conversation
Select FLY, FURB, I, PIE, PYI, RET, RSE, UP and W, and fix every finding: ruff's safe fixes (import sorting, pyupgrade), then by hand: - policyengine-fastapi re-exports JWTDecoder through __all__ and drops two unused imports (the 9 F401s noted in Phase 0). - Two tests build their JSON receipts with json.dumps, not % formatting. - smoke_app uses min() rather than sorted()[0] (ruff 0.16 FURB192). scripts/** is linted as Python 3.11, the shared rules tool's minimum, so import sorting matches policyengine-api byte for byte. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lint job now runs ruff check . on the whole repository, and sim.quality.ruff-lint moves from advisory to enforced with the codes selected in ruff.toml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
added this pull request to stack #755
October 12, 2026 20:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #764
Same-Repository Draft PR Check
PolicyEngine/policyengine-sim-api, not a personal fork.Summary
Phase 1 step 1.8, group 1 of about 8: safe auto-fixes. Stacked on #763.
uv run ruff check .now runs in thelintjob on the whole repository, with ruff pinned to 0.15.22.ruff.tomladds FLY, FURB, I, PIE, PYI, RET, RSE, UP and W. Every finding is fixed (about 270, mostly import sorting and pyupgrade).policyengine-fastapire-exportsJWTDecoderthrough__all__and drops two unused imports (the 9 F401s noted in Phase 0).json.dumpsinstead of%formatting.smoke_appusesmin()instead ofsorted()[0], so ruff 0.16 (FURB192) is clean too.async with ... as resourcewas removed.scripts/**is linted as Python 3.11. There's no rootpyproject.toml, so it was treated as 3.9. 3.11 is the shared rules tool's minimum, and import sorting now matches policyengine-api byte for byte.sim.quality.ruff-lintmoves from advisory to enforced.Testing
All seven projects' test suites pass:
ruff check .passes with 0.15.22 and 0.16.8, and the format check is unchanged.uv.lockfiles are unchanged.🤖 Generated with Claude Code