Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Country models cannot currently supply missing entity groups consistently across the household API and YAML runner. Add an opt-in
TaxBenefitSystem.preprocess_situationhook before entity construction, and recordSimulation.input_group_entitiesso formulas can distinguish supplied memberships from generated defaults. The default hook leaves other countries' behavior unchanged; datasets bypass it and retain their supplied membership provenance.Prerequisite for PolicyEngine/policyengine-us#9999; consumer implementation: PolicyEngine/policyengine-us#10000. Keep in draft while the US consumer and integration are reviewed.
Validation: 49 focused builder, simulation/clone, and dataset-loading tests pass;
make formatpasses. Tests cover caller-copy isolation, singular aliases, explicit empty groups, directSimulationconstruction, clone provenance, variable-only reset, and suffixed flat-file membership columns. No country package or real microdata is required. The full core suite was not run; verification is focused on the construction and loading paths changed here.Documentation review: added the hook/provenance contract to the simulation API reference and source docstrings. Impact: medium (public extension point, opt-in default). Confidence: high for the focused paths; downstream US integration is being tested in the companion draft.