Skip to content

Run app Stylelint in CI; cover all apps in make typecheck and test #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGhenis merged 1 commit into from
Oct 20, 2026
Merged

Run app Stylelint in CI; cover all apps in make typecheck and test #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ jobs:
working-directory: ./app
run: bun run eslint

- name: Run Stylelint (app)
working-directory: ./app
run: bun run stylelint

- name: Check formatting with Prettier (website)
working-directory: ./website
run: bun run format:check
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ jobs:
working-directory: ./app
run: bun run eslint

- name: Run Stylelint (app)
working-directory: ./app
run: bun run stylelint

- name: Check formatting with Prettier (website)
working-directory: ./website
run: bun run format:check
Expand Down
9 changes: 6 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
.PHONY: help install dev build test lint format clean deploy
.PHONY: help install dev build typecheck test-all test lint format clean deploy

help:
@echo "Available commands:"
@echo " make install - Install dependencies"
@echo " make dev - Start Next.js website + calculator dev servers"
@echo " make build - Build the website and calculator"
@echo " make typecheck - Run type checks"
@echo " make test - Run tests"
@echo " make typecheck - Run type checks (app, website, calculator)"
@echo " make test - Run tests (app, website)"
@echo " make lint - Run linters"
@echo " make format - Format code"
@echo " make clean - Clean build artifacts"
Expand All @@ -23,12 +23,15 @@ build:

typecheck:
cd app && bun run typecheck
cd website && bun run typecheck
cd calculator-app && bun run typecheck

test-all:
cd app && bun run test-all

test:
cd app && bun run test
cd website && bun run test

lint:
cd app && bun run lint
Expand Down
3 changes: 2 additions & 1 deletion docs/engineering/skills/repository-guidance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,4 +125,5 @@ No route embeds a GitHub Pages site as a whole page any more: the 2025 year in r

1. Run `make format` to format `app/`, `website/` and `calculator-app/` with Prettier. `app/` has its own Prettier config; `website/` and `calculator-app/` use Prettier's defaults.
2. Run `make lint` to run ESLint (and Stylelint in `app/`) in all three.
3. CI fails on ESLint warnings as well as errors (`--max-warnings 0`), and on files Prettier would reformat, so fix all of them.
3. Run `make typecheck` to type-check all three, and `make test` to run the `app/` and `website/` tests (`calculator-app/` has none). These match CI's type checking and tests jobs.
4. CI fails on ESLint warnings as well as errors (`--max-warnings 0`), and on files Prettier would reformat, so fix all of them.
Loading