Fix v3 bill budget label, reform delete, chart labels and accessibility

[PavelMakarchuk]

Summary

Fixes five reproduced v3 (flagship) problems: a mislabeled federal bill budget, a one-click reform delete, unlabeled chart bars at phone width, 437 unnamed tab stops on the district map, and a parameter search that screen readers could not follow. All changes are in v3 code.

Problems and fixes

1. Federal bill's Economic impacts tab called its revenue "state revenue"

StoredImpactCharts got only impact, so it always said "Annual state revenue loss" and added a − sign. On /us/report/bill/us-hr1425 the Overview said "$225.5bn Annual revenue loss" and Economic impacts said "−$225.5bn Annual state revenue loss".

Fix: StoredImpactCharts now takes the bill. A new storedRevenueMetric in libs/flagship/billMetrics.ts holds the Overview's wording, and both places use it. A federal bill reads "$225.5bn Annual revenue loss"; a state bill keeps "Annual state revenue loss". The amount is unsigned next to the loss or gain word, as in the Overview.

2. Deleting a saved reform was one click, with no confirm and a silent failure

Fix: Delete opens a confirm dialog (DeleteReformDialog, a Radix AlertDialog). It names the reform and says how many of its reports leave the list (they still open from their links). A failed delete or duplicate now shows an error message, and the error clears when another reform opens.

3. Report bar charts dropped category labels at phone width

Recharts' default interval="preserveEnd" hid crowded ticks, so at 375px the Hispanic bar (poverty by race), the middle inequality bar and the middle budget waterfall bar had a value and no name.

Fix: a new getCategoryAxis in flagship/report/charts/barLayout.ts. With interval={0}, each label wraps by word to its own slot, the font shrinks until the longest word fits, and the x-axis grows to hold the label with the most lines. Applied to poverty by race, gender and age, deep poverty by gender and age, inequality, and the budget waterfall.

4. The district map put every district (437) in the tab order, unnamed and with no focus outline

Fix: each Geography gets tabIndex={-1}. The map SVG is now one role="img" with a name that points to the ranked district lists, which carry the values.

5. The parameter search combobox did not tell screen readers which result was highlighted

Fix: each result option has its own id (from useId). The input sets aria-activedescendant to the highlighted option, and sets none while a folder is pointed at, the list is out of date or no results show. The input also sets aria-autocomplete="list".

Not done here: the folder header buttons ("Open folder", the breadcrumb and subfolder rows) are still inside role="listbox". To move them out of the listbox, or to make them options that the arrow keys reach, changes how the results list works for all users. That needs a design decision.

Tracker row order: not in this PR

The paged tracker reads with no ORDER BY get their fix only in #1277 (fix/v3-audit-security). This branch had its own copy of that fix, and a commit on this branch reverts it, so app/src/api/billFeed.ts does not change here.

v2 impact

None. Every changed source file is under components/flagship, pages/flagship or libs/flagship. No legacy v2 page, route, shared chart utility or shared hook changes.

Tests

Each fix has a test that failed before the fix:

• StoredImpactCharts.test.tsx and BillReport.test.tsx: a federal bill reads "Annual revenue loss" with no −, and a state bill keeps "state revenue".
• Reforms.test.tsx: Delete opens an alertdialog and does not delete yet. Confirm deletes and Cancel keeps the reform. The report count is in the prompt. A failed delete or duplicate shows an error, and the error clears on another reform.
• CategoryAxisLabels.test.tsx (jsdom at a 300px card with measured text) and barLayout.test.ts: every bar keeps its label, and long labels wrap.
• DistrictChoroplethMap.test.tsx: no district path is a tab stop, and the map is one named image.
• ParameterSearchBox.test.tsx: aria-autocomplete="list", unique option ids, and aria-activedescendant follows the arrow keys (also in a folder open in place). There is no active option while a folder is hovered or when there are no results.

Checks (from app/): bun run typecheck passes. eslint --max-warnings 0 and prettier --check pass on the changed files. vitest run on the flagship component, page, lib and api folders passes (1,335 tests). The full bun run vitest passes (4,949 passed, 10 skipped).

Note: this PR is based on the open #1274 (fix/v3-relevant-comparisons). Retarget it to main after #1274 merges.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
policyengine-calculator-next	Ready	Preview	Oct 15, 2026 1:52pm UTC
policyengine-website	Ready	Preview	Oct 15, 2026 1:52pm UTC