Repository navigation
Resolve the CI-script exceptions outside the deploy pipeline - #3895
Merged
Merged
Conversation
anth-volk
added this pull request to stack #3888
October 12, 2026 20:30
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3895 +/- ##
===========================================
+ Coverage 45.25% 87.58% +42.33%
===========================================
Files 183 198 +15
Lines 11085 12223 +1138
Branches 1907 2161 +254
===========================================
+ Hits 5016 10706 +5690
+ Misses 5647 921 -4726
- Partials 422 596 +174 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
from
October 13, 2026 16:56
95427f1 to
04ea2b9
Compare
anth-volk
removed this pull request from stack #3888
October 13, 2026 19:26
anth-volk
added this pull request to stack #3917
October 13, 2026 19:26
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
from
October 14, 2026 13:52
04ea2b9 to
cdfa056
Compare
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
3 times, most recently
from
October 14, 2026 18:08
7d5b7c3 to
8b6d1f4
Compare
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
from
October 14, 2026 19:47
8b6d1f4 to
3617d28
Compare
- alembic-v1-check.yml: the folded pytest command becomes one line. - pr.yml: split apt-get update and the Redis install into two steps. - sync-cloud-run-secrets.yml: the master-only gate becomes require_git_ref.sh, tested, and checked before authentication. - cleanup_cloud_run_images.sh: add tests with a fake gcloud. - deploy_observability_collector.sh: group the GITHUB_OUTPUT writes (shellcheck SC2129); behaviour unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The multi-line baseline drops from 10 to 7 (the deploy pipeline remains). The untested-script and shellcheck baselines are empty, so api.ci.workflow-scripts-tested and api.ci.shell-scripts-pass-shellcheck move from ratcheted to enforced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Once a CI-script rule is enforced it has no baseline, so its findings were reported as [registry]. Fall back to the rule whose id ends in the check's name (<repo>.ci.multiline-run-is-script, ...). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
from
October 14, 2026 20:04
3617d28 to
35f8770
Compare
8f85864 replaced the inline, if-guarded "Require master branch" step in sync-cloud-run-secrets.yml with a call to .github/scripts/require_git_ref.sh, but left the step ahead of actions/checkout. The script is not in the workspace until the checkout runs, so every run of the Cloud Run secret sync, including runs from master, would have failed with "No such file or directory" before syncing anything. The gate now runs directly after the checkout and still before GCP authentication, so a run from any other branch stops before it can authenticate. The workflow test only asserted that the gate comes before authentication, which the broken ordering satisfied. It now also asserts that the checkout comes before the gate; against the old ordering it fails with "assert 765 < 625". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3893
Summary
Phase 1 step 1.7, part 1. Stacked on #3890; the deploy-pipeline part is the next PR in the stack.
alembic-v1-check.yml: the folded pytest command is now one line.pr.yml:apt-get updateand the Redis install are now two single-line steps.sync-cloud-run-secrets.yml: the master-only gate is a new tested script,require_git_ref.sh. The existing workflow test now checks that it runs before authentication.cleanup_cloud_run_images.shgets tests with a fakegcloud: keep the newest N, dry run, within the limit, and failed deletes.deploy_observability_collector.sh: theGITHUB_OUTPUTwrites are grouped (shellcheck SC2129). Behaviour is unchanged.api.ci.workflow-scripts-testedandapi.ci.shell-scripts-pass-shellcheckmove from ratcheted to enforced.ci-scriptsguard still attributes its findings to that rule rather than[registry].scripts/rules/stays byte-identical with sim's copy.Testing
tests/unit/test_workflow_guard_scripts.py: 6 pass. The related workflow and deploy-script tests pass too (139).python scripts/run_quality_guards.py: all three guards pass.guard --base-ref rules-followupspasses.python -m unittest discover -s scripts/rules/tests -t .: 75 pass.ruff format/ruff checkand actionlint are clean. All scripts pass shellcheck.🤖 Generated with Claude Code