Repository navigation
Conversation
This was referenced Oct 6, 2026
anth-volk
force-pushed
the
fix/3864-acs-local-regional-defaults
branch
from
October 7, 2026 14:03
9a7ab5e to
04e3d48
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3868 +/- ##
==========================================
+ Coverage 45.22% 45.25% +0.02%
==========================================
Files 183 183
Lines 11073 11085 +12
Branches 1905 1907 +2
==========================================
+ Hits 5008 5016 +8
- Misses 5644 5647 +3
- Partials 421 422 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anth-volk
force-pushed
the
fix/3864-acs-local-regional-defaults
branch
from
October 12, 2026 12:46
301109c to
3c7c0e7
Compare
PolicyEngine.py 6.3.4 adds backward compatibility for the legacy ACS-local source that state and congressional-district simulations use: ACS group quarters are outside the SPM measurement, and its ASEC/PUF records take the certified SPM independence role. With 6.2.7, every SPM calculation on that source stops with SPM_COMPOSITION_REQUIRED. - Pin policyengine[models]==6.3.4 in pyproject.toml and the Dockerfile. The lockfile is regenerated once 6.3.4 is published; until then the lock check fails by design. - 6.3.x certifies policyengine-uk 2.126.12. Update the exact installed catalog counts, measured with 6.3.1, which installs the same US 2.2.1 and UK 2.126.12 models. - The simulation API now reports a null poverty rate for a group with nobody measured (PovertyRateValue). Add a test that economic impact results keep those nulls when returned and stored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
policyengine.py 6.3.4 is published. The lock moves policyengine 6.2.7 -> 6.3.4 and policyengine-uk 2.125.1 -> 2.126.12; policyengine-us 2.2.1 and policyengine-core 3.33.0 are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
force-pushed
the
fix/3864-acs-local-regional-defaults
branch
from
October 13, 2026 21:11
4a9a0d9 to
962a786
Compare
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3864
Blocking dependency
Do not merge or deploy until all of these are done:
uv.lockis regenerated against it.The runtime and Docker image already require
policyengine[models]==6.3.4. Until it is published,uv lock --checkand the image build fail by design.Why 6.3.4: with 6.2.7, every SPM calculation on the certified ACS-local source that states and congressional districts use stops with
SPM_COMPOSITION_REQUIRED. The source predates SPM measurement-scope and independence-role declarations. 6.3.4 adds backward compatibility for such legacy sources:Summary
policyengine[models]==6.3.4in the API runtime and the generic container image. Use the bundle's exact Core 3.33.0, US 2.2.1, UK 2.126.12 and SPM calculator 1.0.0; do not select country packages independently.populace_us_2024, and that states and congressional districts use the certifiedpopulace_us_2024_acs_localdataset through standardregion_datasetsmetadata, notdataset_overlays.nullfor a poverty group with nobody inside the poverty measurement (PovertyRateValue). That is not a measured 0%. A new test confirms economic impact results keep those nulls when returned and stored. API v1 does not parse poverty fields, so no other code change is needed.Catalog compatibility
With 6.3.4's models (US 2.2.1, UK 2.126.12), the installed catalog contains:
These were measured with the published 6.3.1 bundle, which installs the same model versions; 6.3.4 changes no model package. Exact count assertions remain, so future country-package changes require explicit review.
Validation
In an environment with the published 6.3.1 bundle (same Core, US, UK and SPM calculator versions as 6.3.4):
On the branch:
Not yet run: the lockfile refresh and frozen install against 6.3.4, the database-backed integration suite, container builds and live deployment checks. All of these wait for publication.
Deployment scope
nullfor a group with nobody measured. That does not happen for whole states or districts in current data.policyengine-app-v2types these rates as numbers, and its percentage-change text would show NaN for such a group.🤖 Generated with Claude Code