Skip to content

Fix App Engine deploy and startup script false failures#3515

Merged
anth-volk merged 3 commits intomasterfrom
fix/app-engine-deploy-quiet
Apr 27, 2026
Merged

Fix App Engine deploy and startup script false failures#3515
anth-volk merged 3 commits intomasterfrom
fix/app-engine-deploy-quiet

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk commented Apr 27, 2026

Fixes #3514

Summary

  • replace yes | gcloud app deploy with gcloud app deploy --quiet
  • prevent false CI failures after successful App Engine deploys under set -o pipefail
  • remove stale App Engine startup attempts to launch nonexistent policyengine_api/worker.py
  • add a changelog fragment for the deploy/startup fixes

Testing

  • bash -n .github/scripts/deploy_app_engine_version.sh
  • bash -n gcp/policyengine_api/start.sh

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.00%. Comparing base (8a7c1df) to head (d07f6d2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3515   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files          63       63           
  Lines        3418     3418           
  Branches      617      617           
=======================================
  Hits         2632     2632           
  Misses        612      612           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk anth-volk changed the title Use --quiet for staged App Engine deploys Fix App Engine deploy and startup script false failures Apr 27, 2026
@anth-volk anth-volk marked this pull request as ready for review April 27, 2026 20:00
@anth-volk anth-volk merged commit 3565b62 into master Apr 27, 2026
7 checks passed
@anth-volk anth-volk deleted the fix/app-engine-deploy-quiet branch April 27, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Successful App Engine deploys fail CI due to broken pipe

1 participant