Repository navigation
[bug] Import yaml lazily in the YAML publishers - #288
Merged
Merged
Conversation
pyyaml was only installed transitively through hydra-core, which is now optional, so a bare install could not import ccflow. Import it inside YAMLPublisher and PrintYAMLPublisher instead of at module level. Signed-off-by: Pascal Tomecek <40371786+ptomecek@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 203 203
Lines 22488 22488
Branches 1458 1458
=======================================
Hits 21101 21101
Misses 1099 1099
Partials 288 288 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pyyaml is not a declared dependency. It was only installed through hydra-core, which #287 made optional.
ccflow/publishers/file.pyandccflow/publishers/print.pyimportyamlat module level and are loaded byimport ccflow, so a barepip install ccflowcannot import the package.This moves the import into
YAMLPublisher.__call__andPrintYAMLPublisher.__call__, so only those two publishers need pyyaml. CI did not catch this because it installs thedevelopextras.Type of Change
Checklist
make lint)make test)