Repository navigation
chore(sdk): build against plotjuggler_sdk 1.0.0-dev.2 - #377
Merged
Merged
Conversation
SDK 1.0 renames the timestamp member of four builtin structs to timestamp_ns, the name the other sixteen already use: FrameTransform, SceneEntity, SceneEntityDeletion and ImageAnnotations. parser_ros, parser_arrow and parser_protobuf set or read that member and are updated. No behaviour changes: the wire format is the same, and the scalar field that parser_protobuf publishes is still named "timestamp". No plugin version or min_sdk_required moves. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the single SDK pin (
SDK_VERSION) from1.0.0-dev.1to1.0.0-dev.2and adapts the one source break that comes with it.SDK 1.0 renames the timestamp member of four builtin structs from
timestamptotimestamp_ns, the name the other sixteen already use:FrameTransform,SceneEntity,SceneEntityDeletionandImageAnnotations(PlotJuggler/plotjuggler_sdk#239).parser_rosparser_arrowmosaico_objects.cpp, plus testsparser_protobuffoxglove_object_codecs.cpp,protobuf_parser.cpp, plus testsWhat does not change
parser_protobufpublishes is still named"timestamp"; only the C++ member it reads was renamed.versionand nomin_sdk_requiredmoves, per the repo rule that an SDK bump with no new host requirement does not raise a floor.Verification
Built with
./build.sh --sdk-localagainst the SDK branch that will becomedev.2(current SDKmainplus PlotJuggler/plotjuggler_sdk#239):ctest: 109/109 pass.bump_core_version.py --check, thescripts/testsunit tests (84) andcheck_sdk_feature_floors.py(35 plugins) pass.The published
dev.2was cut one commit after that tree: it also contains PlotJuggler/plotjuggler_sdk#241, an addition toplugin_data_api.hpp. CI on this PR builds against the published package and is the check for that.🤖 Generated with Claude Code