Repository navigation
Do not wait for a connection closure - #8
Merged
Merged
Conversation
slawwan
marked this pull request as ready for review
October 6, 2026 07:44
Owner
|
Seems to be related to MagicStack/asyncpg#1361, it should be dropped when asyncpg is fixed |
Pliner
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the lock connection dies silently (no FIN/RST, e.g. after a network blip),
__ensure_connection_establishedhangs forever onawait asyncio.shield(connection.close()): asyncpg cancels the in-flight keep-alive query and waits for the cancellation result on the dead connection without a timeout. The lock is never reacquired.The fix closes the connection in background, the same as in asyncpg-listen#223.
test_reacquire_lock_after_silent_disruptionreproduces it viaTcpProxy.freeze_connections(): fails onmain, passes with the fix.