Repository navigation
Fix flaky proxy teardown - #14
Merged
Merged
Conversation
slawwan
marked this pull request as ready for review
October 6, 2026 17:08
Pliner
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests intermittently fail at
tcp_proxyteardown withCancelledErrorindrop_connections(), e.g. 37441620754, 37437410472, 37437424396, 37480791078.TcpProxy._pipeawaitswriter.wait_closed()infinally. WhenTaskGroupcancels the pipe at that moment, the cancellation propagates to the stream's shared close waiter future, so a laterwait_closed()on the same writer indrop_connections()raisesCancelledError. The fix shields the wait.test_cancelled_pipe_does_not_break_connection_closurereproduces it deterministically: fails onmain, passes with the fix.