Obsolete FindObjectsByType sorting

[Insprill]

In BaseProximityTrigger<THandle>.OnValidate, the two calls to FindObjectsByType request that they be sorted by InstanceId. As of Unity 6000.5, this is obsolete and will be removed in future versions due to the EntityId migration. See the what's new page and FindObjectsSortMode docs for more info.

It doesn't look like sorting is even required here, so it can probably just be removed instead of needing pre/post Unity 6.5 versions.

[martindevans]

Thanks for reporting this. Someone else reported it to me last week on Discord and it's already been fixed, but not yet released.

if you'd like to apply the fix yourself in Assets/Plugins/Dissonance/Core/BaseProximityTrigger.cs replace the code around line 87 with this:

#if UNITY_6000_5_OR_NEWER
    var broadcasters = FindObjectsByType<VoiceProximityBroadcastTrigger>(FindObjectsInactive.Include).Where(a => a.RoomName == RoomName).ToList();
     var receivers = FindObjectsByType<VoiceProximityReceiptTrigger>(FindObjectsInactive.Include).Where(a => a.RoomName == RoomName).ToList();
#else
    var broadcasters = FindObjectsByType<VoiceProximityBroadcastTrigger>(FindObjectsInactive.Include, FindObjectsSortMode.None).Where(a => a.RoomName == RoomName).ToList();
    var receivers = FindObjectsByType<VoiceProximityReceiptTrigger>(FindObjectsInactive.Include, FindObjectsSortMode.None).Where(a => a.RoomName == RoomName).ToList();
#endif

Also in Assets/Plugins/Dissonance/Editor/DissonanceCommsEditor.cs replace the code around line 184 with this:

#if UNITY_6000_5_OR_NEWER
    var comms = FindObjectsByType<DissonanceComms>(FindObjectsInactive.Include);
#else
    var comms = FindObjectsByType<DissonanceComms>(FindObjectsInactive.Include, FindObjectsSortMode.None);
#endif