fix(config): write config atomically via tmp + rename#550
Open
jelmerdehen wants to merge 1 commit intoPixlOne:mainfrom
Open
fix(config): write config atomically via tmp + rename#550jelmerdehen wants to merge 1 commit intoPixlOne:mainfrom
jelmerdehen wants to merge 1 commit intoPixlOne:mainfrom
Conversation
writeFile overwrote the existing config in place. A crash, power loss, or out-of-disk during the write would leave a truncated or corrupt config behind. Write to <path>.tmp and rename, so the destination either holds the previous contents or the full new contents. Clean up the tmp file on error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configuration::savecalls_config.writeFile(path)directly on the destination. A crash, power loss, or out-of-disk during the write leaves a truncated or corrupt/etc/logid.cfgbehind, after which logid fails to start.Fix
Write to
<path>.tmpfirst, thenstd::filesystem::renameover the destination. The destination always holds either the previous contents or the full new contents. Tmp file is removed on error.Test plan
Saveover D-Bus and confirm/etc/logid.cfgupdates atomically.