Fix CellGraph layout validation and PNA examples - #154
Open
ludvigla wants to merge 4 commits into
Open
Conversation
Co-authored-by: ludvigla <ludvigla@users.noreply.github.com>
Co-authored-by: ludvigla <ludvigla@users.noreply.github.com>
Co-authored-by: ludvigla <ludvigla@users.noreply.github.com>
ludvigla
marked this pull request as ready for review
August 14, 2026 12:33
maxkarlsson
approved these changes
Aug 14, 2026
|
|
||
| ### Fixes | ||
|
|
||
| - `CreateCellGraphObject()` now correctly validates the `layout` argument as a |
Contributor
There was a problem hiding this comment.
Maybe we should put this under unreleased? Because 0.19.0 is already out?
Collaborator
Author
There was a problem hiding this comment.
Yeah IDK why the cursor cloud agent thought that was a good idea :-O
vincent-van-hoef
approved these changes
Aug 14, 2026
vincent-van-hoef
left a comment
vincent-van-hoef
left a comment
Contributor
There was a problem hiding this comment.
Nice! Looks good to me.
Co-authored-by: ludvigla <ludvigla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
CreateCellGraphObject()so itslayoutargument accepts a named list of tibble layout tables and validates each table. Update all examples inR/CellGraph.Rto use the PNA example dataset, qualify theclicall, replace percent-based section separators with dashed separators, and synchronize the generated documentation.Fixes: PNA-3326
Type of change
How Has This Been Tested?
git diff --checkpasses.PR checklist: