Remove Tau from Pixelator - #445
Merged
Merged
Conversation
Co-authored-by: Johan Dahlberg <johan.dahlberg@pixelgen.com>
Co-authored-by: Johan Dahlberg <johan.dahlberg@pixelgen.com>
johandahlberg
force-pushed
the
cursor/remove-tau-pna-1953-v2-7397
branch
2 times, most recently
from
August 14, 2026 15:18
57a2cca to
a5f2dbc
Compare
johandahlberg
force-pushed
the
cursor/remove-tau-pna-1953-v2-7397
branch
from
August 14, 2026 15:20
a5f2dbc to
39ddf7a
Compare
johandahlberg
marked this pull request as ready for review
August 14, 2026 15:22
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 19ee885. Configure here.
johandahlberg
force-pushed
the
cursor/remove-tau-pna-1953-v2-7397
branch
from
August 14, 2026 15:32
19ee885 to
6a04a8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Remove the retired Tau aggregate-calling implementation from Pixelator and stop writing
tau,tau_type, andtau_thresholdsto newly generated AnnData objects.pixelator.common.annotate.aggregates(specificity_tau,call_aggregates) and theTAU_*constants.call_aggregatescalls in the PNA graph, denoise, and sample calling paths, so new AnnData no longer carries Tau fields.GraphStatistics/GraphSampleReportand the graph report snapshot, since they were computed solely fromtau_type.tau/tau_typecolumns inadd_missing_adata_info, which otherwise copies them from an old AnnData back into a rebuilt one during denoise and sample calling._add_missing_adata_infoin sample calling was a duplicate of that helper and now delegates to it.Replaces #444, which was based on
devbefore the MPX removal in #439. The MPX portions of that branch (annotate step,--aggregate-callingCLI flag,scatter_umi_per_upia_vs_tauplot, annotate report fields) are obsolete now that the MPX tree is gone.This branch has since been merged up to current
dev. The only conflict wassrc/pixelator/pna/graph_legacy/connected_components.py, which #443 deleted while this branch had edited it to remove its Tau usage; resolved by accepting the deletion.Linear: PNA-1953
Type of change
Existing PXL files remain readable; their stored Tau columns are simply no longer produced or propagated on rewrite.
How Has This Been Tested?
uv run ruff format --check src testsanduv run ruff check src tests— all passuv run pytest tests— 644 passed, 3 skipped, 1 failedtests/cli/test_integration.py::test_command_line_interface, which is pre-existing ondevand unrelated to this PR: #443 removed thegraph_legacyCLI command but left it listed in that test's expected commands. It reproduces identically (AssertionError: graph_legacy) on an unmodifieddevcheckout, so it is not fixed here.tau,tau_type, andtau_thresholdsintests/common/data_generator/test_pixelfile.pyandtests/pna/denoise/test_denoise.py, plus a regression test thatadd_missing_adata_infodoes not restore legacy Tau columns.PR checklist: