Conversation
- Update `AudioEngine` and `AudioScheduler` roles to clarify their relationship with `ApuCore` - Document multi-track capabilities in `MusicPlayer`, including `secondVoice`, `thirdVoice`, and percussion presets - Improve descriptions of audio data structures and their usage in music playback - Refine noise generation explanations and clarify the deterministic nature of LFSR noise across platforms - Add examples for multi-track music arrangements and tempo control in the guide
Add missing `preset` field to AudioEvent documentation for ADSR/LFO support. Complete InstrumentPreset struct documentation with all 14 fields including ADSR envelope, LFO modulation, and waveform refinements. Update NES effects section to reflect ADSR is now implemented with usage examples. Update resolved features section to include ADSR envelopes and LFO modulation. Add preset field documentation to MusicNote struct. Fix incorrect INSTR_PULSE_BASS references to use INSTR_TRIANGLE_BASS in all code examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.