Skip to content

Combined all of the basic stats modifier - #3621

Open
Crepestrom wants to merge 5 commits into
PixelGuys:masterfrom
Crepestrom:Basic-Stat-Modifier-Combined
Open

Crepestrom wants to merge 5 commits into
PixelGuys:masterfrom
Crepestrom:Basic-Stat-Modifier-Combined

Conversation

@Crepestrom

@Crepestrom Crepestrom commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Fixes: #3611
increases maintainability of the code as you do not need to modify 8 basic stat modifiers in the same exact way
Breaks many addons that use the old system of modifiers
Also negative and positive modifiers are combined instead of being applied seperatly
eg: a +50% durability and -50% durability modifier will cancel out to +0% durability instead of -25% durability (75% of total durability)

Before:
image
After:
image

@Wunka Wunka added the Addon Migration Guide Things that should be noted in the Addon migration section of the changelog label Sep 19, 2026
@Wunka Wunka moved this to WIP/not ready for review in PRs to review Sep 19, 2026
@Crepestrom
Crepestrom marked this pull request as ready for review September 19, 2026 19:50
@Crepestrom

Crepestrom commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

Which is better
1
image
or
2
image

@calebstenberg

Copy link
Copy Markdown
Contributor

Which is better

I almost like not seeing Fragile and Powerful and just having the stat change

@oridbot

oridbot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

while I do definitely prefer no names, having names for the stat changes leave room for us to (if the player becomes familiar with those names enough) just state the names without the description. I would say it also gives the tool more of a reason for having these stats

alternatively you could do something like Powerful (+50% dmg) since i think the increases/decreases is kind of redundant when you have the +/-.

@Crepestrom

Crepestrom commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

good point i will remove the increases and decreases
was also drawing away the eye from the number

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Addon Migration Guide Things that should be noted in the Addon migration section of the changelog

Projects

Status: WIP/not ready for review

Development

Successfully merging this pull request may close these issues.

Combine all Basic Stat Modifiers

4 participants